Fix: Pull existing locality values from WB dataset - #8374
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesGEOLocate data flow
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning One or more dependencies are approaching or past End-of-Life. |
|
@CodeRabbit full review |
✅ Action performedFull review finished. Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 58 minutes. |
b975bcd to
3afee39
Compare
Triggered by 3afee39 on branch refs/heads/issue-8322
emenslin
left a comment
There was a problem hiding this comment.
- Verify that the GEOLocate dialog opens with all fields (country, state, county, locality) filled
Looks good, works correctly!
grantfitzsimmons
left a comment
There was a problem hiding this comment.
- In the Workbench, upload a dataset that has columns mapped to locality.latitude1, locality.longitude1, locality.localityname, and geography ranks (locality.geography.$Country.name, etc.) or create one
- Leave the latitude1 and longitude1 cells empty, but fill in the locality and geography cells with real values
- Select one or more rows and click the "GEOLocate" button in the toolbar
- Verify that the GEOLocate dialog opens with all fields (country, state, county, locality) filled
🌐 😄
kwhuber
left a comment
There was a problem hiding this comment.
- In the Workbench, upload a dataset that has columns mapped to locality.latitude1, locality.longitude1, locality.localityname, and geography ranks (locality.geography.$Country.name, etc.) or create one
- Leave the latitude1 and longitude1 cells empty, but fill in the locality and geography cells with real values
- Select one or more rows and click the "GEOLocate" button in the toolbar
- Verify that the GEOLocate dialog opens with all fields (country, state, county, locality) filled
Locality string parsing throws off the pin sometimes, but the fix's overall functionality is correct again!
Fixes #8322
Checklist
self-explanatory (or properly documented)
specify7/specifyweb/specify/management/commands/run_key_migration_functions.py
Line 50 in ea04665
Testing instructions
Summary by CodeRabbit
Bug Fixes
Tests