Fix empty chart output in Google Colab - #182
Open
Ashvanth-gif wants to merge 1 commit into
Open
Conversation
Colab's shell (google.colab._shell.Shell) doesn't subclass ZMQInteractiveShell, so the notebook-type check in set_display_settings() was silently skipped and output_notebook() never ran, leaving Bokeh with no notebook context to render into. Fixes spotify#131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a bug where charts render an empty output when using Chartify in Google Colab. Colab's shell (
google.colab._shell.Shell) doesn't subclassZMQInteractiveShell, so the notebook-type check inset_display_settings()was silently skipped andoutput_notebook()never ran, leaving Bokeh with no notebook context to render into. This PR adds detection for Colab's shell alongside the existing Jupyter/JupyterLab check.Which issue(s) this PR fixes
Fixes #131
Special notes for your reviewer:
Tested manually in a fresh Google Colab notebook using the exact repro from the issue — confirmed the chart failed to render before this fix and rendered correctly after. Also fixed a latent bug where
_IPYTHON_INSTANCE = Truewas missing aglobaldeclaration and was never actually updating the module-level flag.Release note: