Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.Collections;
import java.util.HashMap;
import java.util.Iterator;
import java.util.Locale;
import java.util.Map;
import java.util.Objects;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -370,6 +371,10 @@ static String determinePrefixToUse(Map<String, Object> messageHeaders) {
}

static String extractTargetProtocol(Map<String, Object> messageHeaders) {
String targetProtocol = resolveTargetProtocolHeader(messageHeaders);
if (StringUtils.hasText(targetProtocol)) {
return targetProtocol;
}
Iterator<String> keyIterator = messageHeaders.keySet().iterator();
for (; keyIterator.hasNext();) {
String key = keyIterator.next();
Expand All @@ -383,6 +388,22 @@ else if (key.startsWith("amqp")) {
return null;
}

private static String resolveTargetProtocolHeader(Map<String, Object> messageHeaders) {
Object targetProtocol = messageHeaders.get(MessageUtils.TARGET_PROTOCOL);
if (targetProtocol == null) {
for (Map.Entry<String, Object> entry : messageHeaders.entrySet()) {
if (MessageUtils.TARGET_PROTOCOL.equalsIgnoreCase(entry.getKey())) {
targetProtocol = entry.getValue();
break;
}
}
}
if (targetProtocol instanceof String protocol && StringUtils.hasText(protocol)) {
return protocol.toLowerCase(Locale.ROOT);
}
return null;
}

static String determinePrefixToUse(Map<String, Object> messageHeaders, boolean strict) {
String targetProtocol = extractTargetProtocol(messageHeaders);
String prefix = determinePrefixToUse(targetProtocol);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
package org.springframework.cloud.function.cloudevent;

import java.net.URI;
import java.util.HashMap;
import java.util.Map;
import java.util.UUID;

import org.apache.commons.logging.Log;
Expand Down Expand Up @@ -99,7 +101,8 @@ public Message<?> postProcessResult(Object result, Message<?> input) {

String targetPrefix = CloudEventMessageUtils.DEFAULT_ATTR_PREFIX;
if (input != null) {
targetPrefix = CloudEventMessageUtils.determinePrefixToUse(input.getHeaders(), true);
targetPrefix = CloudEventMessageUtils.determinePrefixToUse(
headersForTargetPrefix(input, result), true);
}
else if (result instanceof Message resultMessage) {
targetPrefix = CloudEventMessageUtils.determinePrefixToUse(resultMessage.getHeaders(), true);
Expand All @@ -119,6 +122,19 @@ public void setApplicationContext(ApplicationContext applicationContext) throws
this.applicationContext = (ConfigurableApplicationContext) applicationContext;
}


private static Map<String, Object> headersForTargetPrefix(Message<?> input, Object result) {
Map<String, Object> headers = new HashMap<>(input.getHeaders());
if (result instanceof Message<?> resultMessage) {
resultMessage.getHeaders().forEach((key, value) -> {
if (value != null) {
headers.putIfAbsent(key, value);
}
});
}
return headers;
}

private Message<?> doPostProcessResult(Object result, String targetPrefix) {
Message<?> resultMessage = null; //result instanceof Message ? (Message<?>) result : null;
CloudEventMessageBuilder<?> messageBuilder;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ public abstract class MessageUtils {
*/
public static String MESSAGE_TYPE = "message-type";
/**
* Value for 'target-protocol' typically use as header key.
* Header key for the target messaging protocol of an outgoing Cloud Event (e.g. kafka, amqp, http).
*/
public static String TARGET_PROTOCOL = "target-protocol";

/**
* Value for 'source-type' typically use as header key.
*/
public static String SOURCE_TYPE = "source-type";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import org.junit.jupiter.api.Test;

import org.springframework.cloud.function.context.message.MessageUtils;
import org.springframework.messaging.Message;
import org.springframework.messaging.support.MessageBuilder;

Expand Down Expand Up @@ -98,6 +99,20 @@ public void testAttributeRecognitionAndCanonicalization() {
assertThat(CloudEventMessageUtils.getSpecVersion(httpMessage)).isEqualTo("1.0");
}


@Test
void determinePrefixToUsePrefersTargetProtocolHeaderOverSourceProtocolHeaders() {
Message<String> ceMessage = CloudEventMessageBuilder.withData("foo")
.build(CloudEventMessageUtils.AMQP_ATTR_PREFIX);
ceMessage = MessageBuilder.fromMessage(ceMessage)
.setHeader(MessageUtils.TARGET_PROTOCOL, "kafka")
.setHeader("amqp_correlationId", "123")
.build();

assertThat(CloudEventMessageUtils.determinePrefixToUse(ceMessage.getHeaders(), true))
.isEqualTo(CloudEventMessageUtils.KAFKA_ATTR_PREFIX);
}

@Test
void buildWithKafkaPrefixUsesContentTypeHeaderForDataContentType() {
Message<String> kafkaMessage = CloudEventMessageBuilder.withData("hello")
Expand Down