Skip to content

Fix flaky Reactor Netty attributes test #37303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnabnandy7 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Fix flaky Reactor Netty attributes test #37303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...test/java/org/springframework/web/reactive/function/client/WebClientIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
import mockwebserver3.RecordedRequest;
import org.eclipse.jetty.client.Request;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
Expand Down Expand Up @@ -1323,10 +1322,12 @@ void retrieveTextDecodedToFlux(ClientHttpConnector connector) throws IOException
.verify(Duration.ofSeconds(3));
}

@Disabled("Disabled because it's flaky (gh-36589)")
@Test // gh-36158
void reactorNettyAttributes() throws IOException {
startServer(new ReactorClientHttpConnector());
Sinks.Empty<Void> connectionReleased = Sinks.empty();
HttpClient httpClient = HttpClient.create()
.doOnDisconnected(connection -> connectionReleased.tryEmitEmpty());
startServer(new ReactorClientHttpConnector(httpClient));

prepareResponse(builder ->
builder.setHeader("Content-Type", "text/plain").body("Hello Spring!"));
Expand All @@ -1342,6 +1343,7 @@ void reactorNettyAttributes() throws IOException {
.bodyToMono(String.class);

StepVerifier.create(result).expectNext("Hello Spring!").expectComplete().verify(Duration.ofSeconds(3));
StepVerifier.create(connectionReleased.asMono()).expectComplete().verify(Duration.ofSeconds(3));

assertThat(channelRef.get().attr(ReactorClientHttpConnector.ATTRIBUTES_KEY).get()).isNull();
}
Expand Down
Loading