Set first batch arg once while executing batch with generated keys - #37308
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
|
Should I create a separated PR for second commit or keep it as is? it's related to new |
sbrannen
added
in: data
Since we typically squash commits in a PR before merging, it would be better to pre-squash them into a single commit with an all-encompassing title such as "Set first batch arg once while executing batch with generated keys". The commit message could then be a combination of the current two commit messages. I'll go ahead and update the current PR title to reflect that. |
sbrannen
changed the title
sbrannen
added
the
status: waiting-for-feedback
|
Should the first commit be backported to 6.x? |
spring-projects-issues
added
status: feedback-provided
6.x is no longer under open source support, and this is more of an enhancement than a bug fix, so we don't plan to backport this. |
`batchArgs[0]` in `NamedParameterJdbcTemplate` and `indexedBatch[0]` in `DefaultJdbcClient` are already set by `pscf::newPreparedStatementCreator`, so it is unnecessary to set them again via `BatchPreparedStatementSetter::setValues`. Closes spring-projectsgh-37308 Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
|
This has been merged into Thanks |
3 participants
batchArgs[0]is already set bypscf::newPreparedStatementCreator, it is unnecessary to set it again byBatchPreparedStatementSetter::setValues.