feat(config): add num_chargers so a repeated charger is caught rather than silently summed - #4880
Open
chalfontchubby wants to merge 2 commits into
Open
feat(config): add num_chargers so a repeated charger is caught rather than silently summed#4880chalfontchubby wants to merge 2 commits into
chalfontchubby wants to merge 2 commits into
Conversation
…mmed car_charging_power is the one car_charging_* key that is not one entry per car: it lists chargers and update_car_charging_power() sums them. Sitting among five keys that ARE indexed by num_cars, it reads as per-car, so a household with two cars sharing one charger naturally lists that charger twice - and Predbat then reports double the power the charger is drawing (#4879). We cannot detect this. Deduplicating identical entity ids catches the literal case but not two template sensors that both read the same charger, and there is no invariant to check the sum against - car_energy_reported_load exists because the charger may sit outside the house CT clamp. A check that caught one shape and stayed silent on the other would be worse than none, since the silence would read as validated. So ask instead. num_chargers names the concept Predbat was missing entirely - it models cars and has no notion of chargers - and lets the existing entries validation compare it against the length of car_charging_power. Unset means no check, so no existing apps.yaml changes behaviour; the shipped template sets 1, which is the common case and the one that gets this wrong. Two supporting changes: entries validation only ever rejected too FEW entries. Extra entries have always been tolerated, and newly rejecting them everywhere would fail working installs - but for a list that is summed rather than indexed an extra entry inflates the total instead of being ignored. Hence entries_exact, set only on this key. The item type check trims a list to required_entries before validating it, so a count key that is simply unset (0) trimmed the list to nothing and type-checked no items at all - which silently disabled the existing "a nonsense charger sensor is rejected" behaviour the moment this key gained an entries rule. Guarded with "if required_entries" rather than "is not None"; the same latent hole applied to every entries key whenever its count was 0. Docs say the missing part out loud: this list describes chargers, not cars, list each one once however many cars you have, and two cars sharing a charger is a single entry. Fixes #4879 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Tolerating a short list silently made num_chargers mean "an upper bound" rather than "how many chargers I have". A charger with no live power sensor is a real and documented setup, so a short list must not force a false count - but an entry deleted by accident under-reports the Car figure just as quietly as a repeated one over-reports it, which is the whole problem this key exists to stop. Log it without recording an arg_error, so a legitimate setup is not left showing "apps.yaml has N errors" forever. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude, posted on behalf of @chalfontchubby.
Fixes #4879
car_charging_poweris the onecar_charging_*key that is not one entry per car: it lists chargers, andupdate_car_charging_power()sums them. It sits among five keys that are indexed bynum_cars, so a household with two cars sharing one charger naturally lists that charger twice — and Predbat reports double the power it is drawing. The reporter's diagram showed 14140 W against a Zappi reading 7.1 kW.Why not just detect it
Deduplicating identical entity ids catches the literal
[zappi, zappi]case, but not this, which is the shape a careful user is more likely to produce:Two distinct entities, one charger. We cannot see through a template sensor to its source, and there is no invariant to check the sum against —
car_energy_reported_loadexists precisely because the charger may sit outside the house CT clamp. A check that caught one shape and stayed silent on the other would be worse than none: the silence would read as "validated".So ask instead
num_chargersnames the concept Predbat was missing entirely — it models cars and has no notion of chargers at all, which is the root of the confusion. The existingentriesvalidation then compares it against the length ofcar_charging_power, catching both shapes because it stops trying to infer something invisible.apps.yamlchanges behaviour.num_chargers: 1— the common case, and the one that gets this wrong.arg_error, so a legitimate setup is never left showing "apps.yaml has N errors".Two supporting changes worth a reviewer's eye
1.
entriesvalidation only ever rejected too FEW entries. Extra entries have always been tolerated, and newly rejecting them everywhere would fail working installs. But for a list that is summed rather than indexed, an extra entry inflates the total instead of being ignored. Hence a newentries_exactflag, set only on this key, so every existing key keeps its current behaviour.2. A latent hole in the item type check. It trims a list to
required_entriesbefore validating the items:With a count key that is simply unset,
required_entriesis0, so the list was trimmed to nothing and no items were type-checked at all. That silently disabled the existing "a nonsense charger sensor is rejected" behaviour the moment this key gained anentriesrule — caught by an existing test, which is how I found it. Guarded withif required_entriesinstead. The same hole applied to everyentrieskey whenever its count was 0.Docs
docs/car-charging.mdsaid only the positive case ("one per line, if you have more than one charger"). It now says the negative out loud: this list describes chargers not cars,num_carshas no bearing on it, list each charger once however many cars you have, and two cars sharing a charger is a single entry. Plus the self-check — comparepredbat.car_charging_poweragainst the charger's own app; if it reads double, an entry is repeated.Testing
Four new cases in
test_web_power_flow: a duplicated charger againstnum_chargers: 1is an error; the same list validates atnum_chargers: 2; fewer entries than declared warns without recording anarg_error; and a nonsense sensor is still type-checked withnum_chargersunset (the truncation regression above)../run_all --quickand./run_all --test debug_casesboth pass.