Skip to content

ci: replace SourceKnight with native GitHub Actions workflow - #32

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 17, 2026
Merged

ci: replace SourceKnight with native GitHub Actions workflow#32
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

Replaces the SourceKnight-based build (maxime1907/action-sourceknight) with a native GitHub Actions workflow, following the same validated job structure used in srcdslab/sm-plugin-AdminRoom.

  • Removed sourceknight.yaml.
  • Rewrote .github/workflows/ci.yml with build / tag / release jobs that install the SourcePawn compiler directly (rumblefrog/setup-sp@v1.3.1, SM 1.12.x) and clone dependencies via git clone --depth=1 instead of the SourceKnight action.
  • Updated .github/copilot-instructions.md and .gitignore to drop remaining SourceKnight references.

Plugin targets compiled

Target Source path
AdvancedAdminList addons/sourcemod/scripting/AdvancedAdminList.sp

Dependencies cloned

Name Repo URL Real include path used
MultiColors https://github.com/srcdslab/sm-plugin-MultiColors addons/sourcemod/scripting/include/ (contains multicolors.inc and multicolors/colors.inc, multicolors/morecolors.inc)

Local spcomp validation performed

Compiled AdvancedAdminList.sp locally with the SourceMod 1.12.0 Windows spcomp (matching the sourcemod type: tar version pinned in the old sourceknight.yaml), against a freshly git clone --depth=1'd copy of sm-plugin-MultiColors's real include directory, replicating exactly what the new CI workflow's "Install dependencies" and "Build sourcemod plugin" steps do. The build succeeded with no errors:

Code size:         46684 bytes
Data size:         472260 bytes
Stack/heap size:      21324 bytes
Total requirements:  540268 bytes

Packaging

The old workflow (via the SourceKnight action's package output) also bundled addons/sourcemod/configs/ (containing advancedadminlist.cfg) alongside the compiled .smx. The new workflow's "Create package" step replicates this by copying addons/sourcemod/configs into the release artifact, matching the AdminRoom reference's packaging pattern (addons/sourcemod/plugins/*.smx + addons/sourcemod/configs/).

Manual verification needed

  • The old workflow nested the config directory under a common/ prefix (/tmp/package/common/addons/sourcemod/configs) as an artifact of the generic SourceKnight package action. The new workflow uses a flat addons/sourcemod/... layout instead (no common/ wrapper), matching the AdminRoom reference exactly. This changes the internal path of advancedadminlist.cfg inside the release tarball — please confirm this flat layout is acceptable / expected for downstream deployment scripts.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 17, 2026 06:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the plugin’s CI/CD from a SourceKnight-driven build to a fully native GitHub Actions workflow that installs spcomp, clones required includes (MultiColors), builds AdvancedAdminList.smx, and publishes release artifacts.

Changes:

  • Removed the SourceKnight build definition (sourceknight.yaml) and cleaned up remaining SourceKnight references.
  • Replaced the CI workflow with a native GitHub Actions pipeline that sets up SourcePawn tooling, clones dependencies, builds the plugin, and packages artifacts.
  • Updated repository documentation/instructions to reflect the new build and dependency flow.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
sourceknight.yaml Removed SourceKnight configuration now that CI is handled by GitHub Actions directly.
.gitignore Removed the .sourceknight ignore entry as SourceKnight is no longer used.
.github/workflows/ci.yml Implemented native build/tag/release jobs (setup spcomp, clone MultiColors, compile, package, publish).
.github/copilot-instructions.md Updated build/tooling documentation to match the new GitHub Actions-based workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Rushaway
Rushaway merged commit a681782 into master Aug 17, 2026
7 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 17, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants