ci: replace SourceKnight with native GitHub Actions workflow - #32
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This pull request migrates the plugin’s CI/CD from a SourceKnight-driven build to a fully native GitHub Actions workflow that installs spcomp, clones required includes (MultiColors), builds AdvancedAdminList.smx, and publishes release artifacts.
Changes:
- Removed the SourceKnight build definition (
sourceknight.yaml) and cleaned up remaining SourceKnight references. - Replaced the CI workflow with a native GitHub Actions pipeline that sets up SourcePawn tooling, clones dependencies, builds the plugin, and packages artifacts.
- Updated repository documentation/instructions to reflect the new build and dependency flow.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sourceknight.yaml |
Removed SourceKnight configuration now that CI is handled by GitHub Actions directly. |
.gitignore |
Removed the .sourceknight ignore entry as SourceKnight is no longer used. |
.github/workflows/ci.yml |
Implemented native build/tag/release jobs (setup spcomp, clone MultiColors, compile, package, publish). |
.github/copilot-instructions.md |
Updated build/tooling documentation to match the new GitHub Actions-based workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow, following the same validated job structure used insrcdslab/sm-plugin-AdminRoom.sourceknight.yaml..github/workflows/ci.ymlwithbuild/tag/releasejobs that install the SourcePawn compiler directly (rumblefrog/setup-sp@v1.3.1, SM 1.12.x) and clone dependencies viagit clone --depth=1instead of the SourceKnight action..github/copilot-instructions.mdand.gitignoreto drop remaining SourceKnight references.Plugin targets compiled
addons/sourcemod/scripting/AdvancedAdminList.spDependencies cloned
addons/sourcemod/scripting/include/(containsmulticolors.incandmulticolors/colors.inc,multicolors/morecolors.inc)Local spcomp validation performed
Compiled
AdvancedAdminList.splocally with the SourceMod 1.12.0 Windowsspcomp(matching thesourcemodtype: tarversion pinned in the oldsourceknight.yaml), against a freshlygit clone --depth=1'd copy ofsm-plugin-MultiColors's real include directory, replicating exactly what the new CI workflow's "Install dependencies" and "Build sourcemod plugin" steps do. The build succeeded with no errors:Packaging
The old workflow (via the SourceKnight action's package output) also bundled
addons/sourcemod/configs/(containingadvancedadminlist.cfg) alongside the compiled.smx. The new workflow's "Create package" step replicates this by copyingaddons/sourcemod/configsinto the release artifact, matching the AdminRoom reference's packaging pattern (addons/sourcemod/plugins/*.smx+addons/sourcemod/configs/).Manual verification needed
common/prefix (/tmp/package/common/addons/sourcemod/configs) as an artifact of the generic SourceKnight package action. The new workflow uses a flataddons/sourcemod/...layout instead (nocommon/wrapper), matching the AdminRoom reference exactly. This changes the internal path ofadvancedadminlist.cfginside the release tarball — please confirm this flat layout is acceptable / expected for downstream deployment scripts.