chore(ci): replace SourceKnight with setup-sp - #83
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight@v1) with a native GitHub Actions workflow usingrumblefrog/setup-spandspcomp, following the org-wide rollout pattern (seesrcdslab/sm-plugin-AdminRoomas the validated reference).Plugin targets
addons/sourcemod/scripting/CustomChatColors.spDependencies (from
sourceknight.yaml)/addons→/addons/addons→/addons/game/addons→/addons/scripting/include→/addons/sourcemod/scripting/include(
sourcemodtype: tarruntime dependency omitted from the table above — it is now provided byrumblefrog/setup-spinstead, pinned to1.12.xper the org-wide migration standard, regardless of the version previously pinned insourceknight.yaml.)Packaging
The new workflow packages the compiled
.smxplusaddons/sourcemod/configsandaddons/sourcemod/translations, both of which exist in this repo tree (mirroring what the old SourceKnight-based workflow copied into the package).Not locally validated
This is a lightweight migration pass: no dependency repos were cloned locally, no
spcompwas run, and no local compilation was performed. The workflow's correctness (dependency include paths, compile success, packaging) relies entirely on the GitHub Actions CI run triggered by this PR. Please review the CI results before merging.Manual verification needed
sourceknight.yamlwithout independently verifying the internal directory layout of each dependency repo. If CI fails on a missing include, the most likely culprit is a mismatchedunpackpath for one ofmulticolors,SelfMute,sourcebans-pp, ordynamicchannels.csgo-legacyandnew-multicolorsbranches that were not migrated by this PR (onlymaster, the default branch, was touched).