chore(ci): replace SourceKnight with setup-sp - #40
Merged
Conversation
Rushaway
force-pushed
the
chore/drop-sourceknight
branch
from
August 18, 2026 08:06
4dfd689 to
cdf01a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow that installs the SourcePawn compiler viarumblefrog/setup-spand compiles the plugin directly, matching the pattern already rolled out to 59 other srcdslab repos (reference:srcdslab/sm-plugin-AdminRoom).Plugin targets
addons/sourcemod/scripting/FunModes.spDependencies (as declared in
sourceknight.yaml, not independently verified)/addons/sourcemod/scripting/include→/addons/sourcemod/scripting/include/scripting/include→/addons/sourcemod/scripting/include/src/addons/sourcemod/scripting/include→/addons/sourcemod/scripting/include/addons/sourcemod/scripting/include→/addons/sourcemod/scripting/include/addons/sourcemod/scripting/include→/addons/sourcemod/scripting/includeThe
sourcemod(type: tar) dependency was dropped from the dependency-install step, matching the reference workflow which relies solely onrumblefrog/setup-spfor the compiler/include toolchain.SourceMod version pinned to
1.12.xinrumblefrog/setup-sp(fixed per migration policy, regardless of the exact1.12.0-git7221version previously declared insourceknight.yaml).Packaging
The old workflow copied
.sourceknight/package/*plusaddons/sourcemod/translationsinto the release package. The newCreate packagestep copies the real, existing paths found in the repo tree:addons/sourcemod/plugins/*.smxaddons/sourcemod/configsaddons/sourcemod/translationsNo
common/,cfg/,materials/,models/, orgamedata/directories exist in this repo, so nothing else was added.Not locally validated
This migration was done without cloning dependency repos or running
spcomplocally, per the lightweight migration policy. Dependency paths above are taken as declared insourceknight.yamland have not been independently verified. CI on this PR will be the first real build/compile validation.Manual verification needed
DynamicChannelsandKnockbackRestrictare consumed via#tryinclude(optional/soft dependency) inFunModes.spandFun_Modes/CrazyShop.sprespectively. They are still cloned and their includes copied in the new workflow (matching the declaredsourceknight.yamldependencies), but since they're optional includes, please confirm the build succeeds/behaves as expected either way.