[release-v1.33] add generic metrics for external API (#1228)#1351
Merged
Conversation
* add genetric metrics for external API * make fmt * add tests for the new http error metrics * remove loadbalancer prefix from metrics names * add tests for HTTPRequestDurationHistogram and HTTPRequestCount * add api label from client creation * make mod tidy * add metrics for csi * call metric server from csi/main.go * create prometheus metrics exporter * remove api name required check and update tests * remove error from func * make status_code * make add more labels in new metrics * make lint * fix test * optimize code
ske-prow
Bot
added
kind/cherry-pick
aniruddha2000
approved these changes
Jul 9, 2026
|
@aniruddha2000: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
xoxys
approved these changes
Jul 9, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aniruddha2000, xoxys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
Bot
added
lgtm
|
LGTM label has been added. DetailsGit tree hash: 2457974f0baeb5e0b0607fd24db877ec54a4e584 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind cherry-pick
What this PR does / why we need it:
Cherry-pick of #1228
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: