Added spec.podTemplateSpec support to MCPRemoteProxy

[Sanskarzz]

Summary

Add spec.podTemplateSpec support to MCPRemoteProxy so remote proxy workloads can be customized like the other ToolHive workload CRDs.

Although the issue calls out v1alpha1, this branch defines v1alpha1.MCPRemoteProxy.Spec as v1beta1.MCPRemoteProxySpec, so the API field is added to the shared v1beta1 spec. Regenerated CRDs expose the field in both served schema sections.

Fixes #4549

Type of change

• Bug fix
• New feature
• Refactoring (no behavior change)
• Dependency update
• Documentation
• Other (describe):

Test plan

• Unit tests (task test)
• E2E tests (task test-e2e)
• Linting (task lint-fix)
• Manual testing (describe below)

API Compatibility

• This PR does not break the v1beta1 API, OR the api-break-allowed label is applied and the migration guidance is described above.

Changes

• Added optional spec.podTemplateSpec to MCPRemoteProxySpec using runtime.RawExtension with unknown-field preservation.
• Added MCPRemoteProxy-specific PodTemplateValid condition type and valid/invalid reasons.
• Validates PodTemplateSpec early in the MCPRemoteProxy reconcile path and blocks Deployment updates when invalid.
• Applies valid PodTemplateSpec customizations to the generated Deployment using the existing controllerutil.ApplyPodTemplateSpecPatch strategic merge helper.
• Tracks raw PodTemplateSpec changes with the shared toolhive.stacklok.io/podtemplatespec-hash annotation.
• Added focused tests for validation, merge behavior, fields outside the builder emptiness check, and drift detection.
• Regenerated deepcopy, CRDs, Helm CRD templates, and CRD reference docs.

[codecov]

Codecov Report

❌ Patch coverage is 75.33333% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.79%. Comparing base (59d8466) to head (e961b43).

Files with missing lines	Patch %	Lines
...-operator/controllers/mcpremoteproxy_controller.go	77.95%	15 Missing and 13 partials ⚠️
...-operator/controllers/mcpremoteproxy_deployment.go	60.86%	6 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5531      +/-   ##
==========================================
- Coverage   70.80%   70.79%   -0.01%     
==========================================
  Files         685      685              
  Lines       69460    69592     +132     
==========================================
+ Hits        49181    49269      +88     
- Misses      16682    16714      +32     
- Partials     3597     3609      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ChrisJBurns]

@Sanskarzz Thanks for this! Just wanted to add a comment so you don't think we've forgotten, just a bit busy atm. I'll be reviewing it soon enough though! 🚀 😆

[Sanskarzz]

Thanks @ChrisJBurns , no worries at all. Appreciate the update! I’ll keep an eye out for the review and will address any feedback once you get a chance to look at it.

[aponcedeleonch]

Nice work. This is the last workload CRD missing podTemplateSpec, so it's a welcome parity fix, and the implementation mirrors the MCPServer reference closely. The logic checks out for me. Two things are blocking it right now, both mechanical:

• cmd/thv-operator/controllers/mcpremoteproxy_controller.go:398 has a gofmt slip (spaces instead of a tab on a closing brace), which fails the Lint job. A task lint-fix should sort it.
• mcpremoteproxy_podtemplatespec_test.go references createRunConfigTestScheme, which no longer exists on main. It got renamed to testutil.NewScheme(t). Looks like merge rot, and it breaks the whole controllers test package, so the Test job is red too. Swapping to testutil.NewScheme(t) and adding the internal/testutil import fixes it.

I applied both locally and the new PodTemplateSpec tests plus the full controllers package go green, so once those land I think this is good to merge. One non-blocking nit: the rawPodTemplateSpecJSON helper unmarshals into a throwaway map and then discards it, so that validation is effectively dead code. Up to you.

[Sanskarzz]

Thanks for the review! Fixed both blocking issues:

• Ran task lint-fix and corrected the gofmt slip in mcpremoteproxy_controller.go.
• Replaced the stale createRunConfigTestScheme() usage with testutil.NewScheme(t) in the new PodTemplateSpec tests.
• Also cleaned up the rawPodTemplateSpecJSON helper by removing the unused throwaway JSON unmarshal.

[aponcedeleonch]

nice! thanks