Refactor OpenShell client capabilities

[robbycochran]

Summary

• define consumer-scoped gateway capability interfaces
• make planning and reconciliation depend only on the operations they use
• retain one aggregate SDK client and factory

Validation

• gofmt
• git diff --check
• actionlint .github/workflows/*.yml
• shell syntax checks
• local Go tests blocked by installed Go 1.19 versus go 1.25.0; GitHub CI is authoritative

Summary by CodeRabbit

• Refactor
  • Added focused interfaces for reading system state and reconciling providers and inference routes.
  • Updated planning and reconciliation workflows to depend on only the capabilities they require.
  • Confirmed the client supports the new interfaces without changing existing reconciliation behavior.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: aeb345ff-a996-4cec-9a91-8ce6601db735

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 147e5812-4c83-4814-b1bf-e070056b2c80

📥 Commits

Reviewing files that changed from the base of the PR and between dabd1ff and dc86f5f.

📒 Files selected for processing (5)

• internal/openshell/client.go
• internal/openshell/sdkclient/client.go
• internal/plan/state.go
• internal/reconcile/inference.go
• internal/reconcile/provider.go

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

Walkthrough

Changes

Interface narrowing

Layer / File(s)	Summary
Focused interface contracts internal/openshell/client.go, internal/openshell/sdkclient/client.go	Adds focused interfaces for state reads and provider or inference reconciliation. The SDK client asserts conformance to the reconciliation and state interfaces.
Planning and reconciliation consumers internal/plan/state.go, internal/reconcile/provider.go, internal/reconcile/inference.go	Updates planning and reconciliation entry points to accept the required focused interfaces. Existing behavior remains unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to dc86f

This refactor narrows OpenShell client dependencies without changing planning or reconciliation behavior. The aggregate SDK client remains compatible with the new interfaces, and no current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: narrowing and refactoring OpenShell client capabilities for consumer-scoped interfaces.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 5 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rc/refactor-openshell-capabilities

---

_{Comment @coderabbitai help to get the list of available commands.}

[robbycochran]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.