[6.x] Fix editing date fields displayed in a timezone other than the browser's - #15500
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
modelValue?.start alone left an end-only range falling back to the browser-local placeholder, reintroducing the day-period bug for that case. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the AM/PM segment of a date field would flip on every edit when the field's timezone differs from the browser's timezone.
This was happening because
reka-uiderived the day period from the browser's timezone rather than theZonedDateTime's own timezone, so typed hours were interpreted with the wrong period. It has been fixed upstream in unovue/reka-ui#2953, so this PR bumpsreka-uito2.10.5.This PR also fixes an issue where typing a time into a range date field would save it in the browser's timezone rather than the field's. This was happening because the range picker always passed a browser-local
default-placeholder, whichreka-uiuses as the base for typed values. I've fixed it by only passing the placeholder when there's no value, soreka-uifalls back to the range's start date instead.Fixes #15481