Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13111 augmented appended form config fields for Antlers, but only in
Forms\Tags. The email view buildsform_configthe same way and was missed, so{{ form_config:* }}in an email template still receives raw, unaugmented values.For scalar fieldtypes this goes unnoticed, since the raw and augmented values render the same. It shows up as soon as the appended field is something else: a Bard field renders its raw array (
Array to string conversion), and an assets field hands you the filename string instead of an asset, so{{ form_config:download:permalink }}comes out empty.This applies the same one-line change as #13111 to
Forms\Email::addData(), plus a test mirroring the one added there.Found while adding a per-form download to the submitter's email, where the appended config field points at the asset to link.