test: migrate stats/base/dists/weibull/stdev to ULP-based assertions - #14469
Merged
Conversation
Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/base/dists/weibull/stdevfrom relative-tolerance assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, per the guidance in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.jsandtest/test.native.jsto mirror the idiom used in previously converted packages (e.g.stats/base/dists/chi/stdev,stats/base/dists/erlang/stdev,stats/base/dists/frechet/variance).170.0 * EPS * abs( expected[ i ] )(test/test.js) and180.0 * EPS * abs( expected[ i ] )(test/test.native.js) tolerance loops witht.strictEqual( isAlmostSameValue( y, expected[ i ], 277 ), true, 'returns expected value' ).@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.The tightest ULP bound was determined empirically by measuring the maximum ULP difference over the full 500-value Julia fixture set:
test/test.js: N = 277 ULP. The measured maximum ULP difference over the fixtures is exactly 277; the worst case isk = 10.905349225171449, lambda = 1.9805794474478602, wherestdev( k, lambda )returns0.2095944993595373against an expected value of0.20959449935952962. Lowering the bound to276fails that fixture, so277is the minimum passing integer.test/test.native.js: N = 277 ULP. The native add-on was built locally for this package, and the maximum ULP difference for the C implementation over the same fixtures is likewise exactly 277, so the bound matches the JavaScript implementation.Both
test/test.jsandtest/test.native.jswere run twice at the finalN = 277(514 assertions each, all passing, with the native add-on built so the native tests were not skipped) to confirm the bound is deterministic.Only the two test files are changed.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code (Anthropic) running as an unattended scheduled task. The conversion mirrors the exact idiom used in previously merged ULP migrations authored by the PR author (e.g. #14447, #14457), and the ULP bound was measured empirically against the existing Julia fixtures and confirmed tight (276 fails, 277 passes) for both the JavaScript and the locally built C implementation.
@stdlib-js/reviewers
Generated by Claude Code