chore: collect maintenance notes and stabilize checks - #3567
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 11, 2026, 8:33 PM ET / September 12, 2026, 00:33 UTC (Revision 4). ClawSweeper reviewWhat this changesUpdates unreleased maintenance notes, isolates Claude retry fixtures from authentication subprocess startup, and gives the process-cleanup sentinel more startup time. Merge readiness⛔ Blocked before merge - 2 items remain The patch is focused and has no actionable correctness findings. It remains useful beyond current main, and the owner's explicit landing order still applies: all five prerequisite PRs remain open. Priority: P3 Review scores
Verification
How this fits togetherCodexBar's checks exercise provider retry behavior and subprocess cleanup before changes ship. This patch adjusts test setup and collects release notes without changing application behavior. flowchart TD
A[Claude retry fixtures] --> B[Task-scoped authentication prerequisite]
B --> C[Existing retry assertions]
D[Process sentinel startup] --> E[Existing timed cleanup assertions]
F[Related code and documentation PRs] --> G[Unreleased maintenance notes]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the focused fixture changes and publish the consolidated notes after their corresponding code and documentation land. Do we have a high-confidence way to reproduce the issue? Not applicable to a product bug: this patch stabilizes test prerequisites. The owner reports successful subprocess and focused Swift runs; this read-only review did not execute them. Is this the best way to solve the issue? Yes. Reusing the task-scoped authentication hook and extending setup time preserve the assertions that actually test retry and cleanup behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 830cdd86c4b6. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
|
Verified head The real-subprocess cleanup suite ran 101 tests successfully (one existing platform skip). Its measured cleanup deadlines, ownership checks, and unrelated-sentinel checks remain intact. On this exact notes head, 27 Swift tests across Claude retry, auth-status, and background-availability suites passed; the retry fixtures no longer start an unrelated authentication shell. Make check and final independent P0–P2 branch review pass. Released changelog sections were compared byte-for-byte and are unchanged. The Unreleased section centralizes the batch's behavior notes and contributor credit. No additional safe dependency bump was needed after #3564. Ready to squash last, after #3539, #3566, #3547, #3525 and #3544. The sequencing warning is intentional: do not put their notes on main before their code/docs. No release or tag is authorized by this PR. |
Restore Cursor app-token authentication on Linux with absolute XDG/HOME resolution, read-only database access, and preserved manual/cached-session precedence. Keep explicit web mode manual-cookie only and treat Grok Bot failures as best effort. Validated with exact-head CI, independent Linux release-CLI authentication against the same database as v0.59.0, regression tests, lint, and independent review. Changelog and credit are centralized in #3567. Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Measure active Codex scan time inside the shared serial executor and use that duration in both automatic catch-up workers. Preserve resource policy, initial delays, scan budgets, cancellation, and complete-history publication. Refs #3508 and #3411; both broader reports remain open. Validate queue contention and both scheduler consumers, retain exact architecture fingerprints, and centralize the release note in #3567.
Add an optional Agent Sessions menu filter for failed remote-host fetches, off by default for fresh and existing settings. Preserve retries, reachable/local rows, diagnostic restoration, and explicit saved choices. Complete locale coverage and prove the production settings and controller path with a signed, isolated native host. Changelog and contributor credit are centralized in #3567. Co-authored-by: Wayne Arthurton <202251+warthurton@users.noreply.github.com>
Collect the batch-six notes in the existing 0.59.1 Unreleased section, ordered by user impact, and fix a process-check setup flake observed repeatedly on a loaded Mac.
The Claude usage-retry fixtures now set their authenticated-CLI prerequisite through the existing task-scoped test hook, removing an unrelated shell startup and its potential 30-second timeout. Retry counts, timeouts, and dedicated authentication-probe tests are unchanged.
The sentinel's interpreter/file startup now gets up to ten seconds before cleanup timing begins. The actual two-second cleanup timeout, bounded teardown, child-ownership checks, and unrelated-sentinel assertions are unchanged. The 101-test process-cleanup suite passes with real subprocesses, and independent P0–P2 review is clean.
This is the only batch PR that changes CHANGELOG.md. Merge after #3539 (Linux Cursor), #3566 (Codex catch-up timing), #3547 (opt-in host hiding), #3525 (Windows companion link), and #3544 (AI Monitor link). Existing notes and contributor credit are retained; released sections are unchanged.
No newly stale small dependency was found beyond #3564's refresh. Previously held compiler/major-version migrations remain separate. The queue still needs another batch, so this does not authorize a tag or release. Exact-head CI passed: https://github.com/steipete/CodexBar/actions/runs/34659109403. The exact notes head also passed 27 focused Swift tests across retry, auth-status, and background-availability suites.