Skip to content

fix(auth): validate resolved credentials in status checks - #46

Merged
stephendolan merged 1 commit into
mainfrom
stephen-codex/fix-ynab-auth-status
Aug 4, 2026
Merged

fix(auth): validate resolved credentials in status checks#46
stephendolan merged 1 commit into
mainfrom
stephen-codex/fix-ynab-auth-status

Conversation

@stephendolan

Copy link
Copy Markdown
Owner

Summary

Authentication status now reports working YNAB_API_KEY credentials the same way as keychain credentials, while rejecting invalid tokens through a lightweight YNAB user lookup. Credential rotation refreshes the cached client, and network or rate-limit failures remain operational errors instead of being mislabeled as invalid authentication.

Validation covered valid keychain and environment credentials, invalid environment credentials, missing credentials, CLI and MCP serialization, transient failures, and token non-disclosure. Both Bun and Vitest passed all 45 tests, with typecheck, lint, build, and package dry-run also passing.

Problem

ynab auth status and MCP check_auth only inspected keychain storage, so a successfully working YNAB_API_KEY still appeared unauthenticated.

Post-Deploy Monitoring & Validation

  • Confirm ynab auth status and MCP check_auth return true for valid keychain and environment credentials, and false for invalid credentials.
  • Treat environment credentials still reporting false, tokens appearing in output, or transient API errors being reported as invalid credentials as release failures.
  • Verify the GitHub release and npm package at v2.8.3; roll back the release if those checks fail.

@stephendolan
stephendolan merged commit 769163f into main Aug 4, 2026
1 check passed
@stephendolan
stephendolan deleted the stephen-codex/fix-ynab-auth-status branch August 4, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant