Use stdlib datetime module to parse D-Bus dates - #1291
Conversation
70b305c to
71dcf9d
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe CLI removes ChangesTimestamp Parsing Migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR replaces an external timestamp parser with Python’s standard library while preserving the existing display behavior. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/packit build |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
1 similar comment
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
The datetime method fromisoformat() method's contract declares that it parses a date string given in any valid ISO 8601 format. stratisd uses the DateTime::to_rfc3339_opts() method, which guarantees to produce an ISO 8601 formatted date string. Assisted-by: Claude:claude-sonnet-4-5 Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>
71dcf9d to
4dc8e23
Compare
Closes stratis-storage/project#895