Conversation
…assing (4 test cases, 28 assertions)
Contributor
|
just remove the old trapezoidal map and use the new one for everything. Just rename trapezoidalmapFAST trapezoidalmap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The original trapezoidal map implementation needs excessive memory for large lookup tables (LUT) (e.g., 300+ MB for tables with ~80k points). This PR introduces a new memory-efficient trapezoidal map implementation (LUT_FAST) for Flamelet-Generated Manifold (FGM) lookup tables, based on LUT algorithm of Pedro Gomes. The new implementation reduces memory usage while maintaining query performance. A new unit test is created and all tests are passed.
Related Work
This code is an implementation of https://github.com/pcarruscag/LUT to SU2.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.