New flamelet solver structure#24
Merged
Merged
Conversation
…to code_cleaning
…to FlameletSolver class
…se class by different child classes.
…rsions of Cantera
Collaborator
|
nice work, once this is in, I will cut up my PR into smaller ones. |
bigfooted
reviewed
Jul 15, 2026
bigfooted
approved these changes
Jul 15, 2026
bigfooted
left a comment
Collaborator
There was a problem hiding this comment.
Good to go, I will add some additional regression tests later for the 2D LUT en the counterflow flame. For counterflow I would like to get the fixed-strain in (very limited use case) and the variable strain with scalar dissipation rate as controlling variable in SU2.
Co-authored-by: Nijso <nijso@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The flamelet data generation workflow was turning into spaghetti, making it very difficult to read the code and understand the workflow. Furthermore, adding new flamelet types was becoming more and more difficult.
I introduced a new flamelet solver structure, where each flamelet type is calculated by a separate class, all of which can be found in FlameletSolvers.py.
This new structure should make it very easy to add new flamelet types, by only having to modify the FlameletSolvers.py file. It also allows for flamelet simulations to be run outside the main SU2 DataMiner workfow, in case you just want to have one or two flamelet simulations with specific settings to experiment with. The rest of the SU2 DataMiner workflow has been modified to support this new flamelet solver structure.
Another new feature is to enable the restart of flamelet simulations from saved .csv data files. This required a modification of the Cantera source code, for which a PR has been merged already with the official Cantera repository. I expect this functionality to be included in the next public version of Cantera.
Related Work
The new solver structure for counter-flow diffusion flamelets at fixed strain has been included in the new flamelet solver structure #22.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.