Skip to content

New flamelet solver structure#24

Merged
EvertBunschoten merged 64 commits into
developfrom
code_cleaning
Jul 15, 2026
Merged

New flamelet solver structure#24
EvertBunschoten merged 64 commits into
developfrom
code_cleaning

Conversation

@EvertBunschoten

@EvertBunschoten EvertBunschoten commented Jul 10, 2026

Copy link
Copy Markdown
Member

Proposed Changes

The flamelet data generation workflow was turning into spaghetti, making it very difficult to read the code and understand the workflow. Furthermore, adding new flamelet types was becoming more and more difficult.

I introduced a new flamelet solver structure, where each flamelet type is calculated by a separate class, all of which can be found in FlameletSolvers.py.

This new structure should make it very easy to add new flamelet types, by only having to modify the FlameletSolvers.py file. It also allows for flamelet simulations to be run outside the main SU2 DataMiner workfow, in case you just want to have one or two flamelet simulations with specific settings to experiment with. The rest of the SU2 DataMiner workflow has been modified to support this new flamelet solver structure.

Another new feature is to enable the restart of flamelet simulations from saved .csv data files. This required a modification of the Cantera source code, for which a PR has been merged already with the official Cantera repository. I expect this functionality to be included in the next public version of Cantera.

Related Work

The new solver structure for counter-flow diffusion flamelets at fixed strain has been included in the new flamelet solver structure #22.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • I have updated the list of python modules in required_packages.txt and environment.yml, if necessary.
  • I have properly commented my changes.
  • I have updated the documentation, if necessary.
  • I have added a test case that demonstrates my contribution, if necessary.

@EvertBunschoten EvertBunschoten self-assigned this Jul 10, 2026
@EvertBunschoten EvertBunschoten added the enhancement New feature or request label Jul 10, 2026
@EvertBunschoten EvertBunschoten changed the title [WIP] New flamelet solver structure New flamelet solver structure Jul 14, 2026
@bigfooted

Copy link
Copy Markdown
Collaborator

nice work, once this is in, I will cut up my PR into smaller ones.

Comment thread Common/DataDrivenConfig.py Outdated

@bigfooted bigfooted left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, I will add some additional regression tests later for the 2D LUT en the counterflow flame. For counterflow I would like to get the fixed-strain in (very limited use case) and the variable strain with scalar dissipation rate as controlling variable in SU2.

Co-authored-by: Nijso <nijso@hotmail.com>
@EvertBunschoten
EvertBunschoten merged commit d6fea47 into develop Jul 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants