constant strain rate diffusion flame#25
Open
bigfooted wants to merge 3 commits into
Open
Conversation
bigfooted
changed the title
| data_interp = self._lookup_tree(q=CV_scaled,nnear=self._n_near,p=self._p_fac) | ||
| return data_interp | ||
|
|
||
| def VisualizeTableLevel(self, val_mix_frac:float, var_to_plot:str=None): |
Member
There was a problem hiding this comment.
I suggest putting the changes to the table generator in a separate PR. See #23 for upcoming changes.
Comment on lines
+5
to
+9
| os.environ.setdefault("OMP_NUM_THREADS", "1") | ||
| os.environ.setdefault("OPENBLAS_NUM_THREADS", "1") | ||
| os.environ.setdefault("MKL_NUM_THREADS", "1") | ||
| os.environ.setdefault("VECLIB_MAXIMUM_THREADS", "1") | ||
| os.environ.setdefault("NUMEXPR_NUM_THREADS", "1") |
Member
There was a problem hiding this comment.
What is the purpose of these commands? Is it something that should be integrated into the workflow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Some changes to fix the constant strain rate diffusion flame, fix logging info, added visualisation options, and added a testcase for a 2D fixed strain rate laminar diffusion LUT
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.