fix(cli): forward function requests without cloning (CLI-2415) - #6580
Open
7ttp wants to merge 3 commits into
Open
fix(cli): forward function requests without cloning (CLI-2415)#65807ttp wants to merge 3 commits into
7ttp wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
The request-forwarding fix is correct, and no runtime correctness or security defect was found. Of Claude’s four findings, two quality concerns are confirmed, one test-reliability concern remains uncertain without reproducing the pre-fix behavior, and the naming concern is refuted. Codex reported no findings.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/shared/functions/serve-main-offline.e2e.test.ts:500 |
test-reliability |
claude | The regression test may not reliably exercise the pre-fix body-stream stall, and timeout failures lack container diagnostics. |
| 🟡 MINOR | packages/stack/src/functions/serve.main.ts:198 |
test-coverage |
claude | The stack-owned request-forwarding fix has no regression test covering an early response while its request body remains unread. |
| ⚪ NIT | apps/cli/src/shared/functions/serve.main.ts:291 |
maintainability |
claude | Neither request-forwarding implementation documents the non-obvious requirement not to clone the request, allowing the body-tee stall to be reintroduced. |
Refuted findings (kept for transparency, not posted as review comments)
apps/cli/src/shared/functions/serve.main.ts:288(naming): The clonedURL identifier is stale because the function no longer clones anything.
Refuted: The identifier still accurately describes the distinct URL object created from the request URL at line 288; only the Request clone was removed.
Stats
Claude findings: 4 · Codex findings: 0 · Confirmed: 2 · Refuted: 1 · Uncertain: 1
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
7ttp
force-pushed
the
7ttp/cli-2415-cli-request-cloning-can-stall-an-early-edge-function
branch
from
September 11, 2026 19:34
87bff55 to
74c0892
Compare
kallebysantos
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Prevents early Edge Function responses from stalling locally.
Cloning tees the request body, leaving an unused stream branch that can block early responses,
which we've now fixed by forwarding the body without cloning and covering the failure with a runtime regression test.
ref: