fix: default Database generic to any, matching createClient() - #156
Open
mandarini wants to merge 1 commit into
Open
fix: default Database generic to any, matching createClient()#156mandarini wants to merge 1 commit into
mandarini wants to merge 1 commit into
Conversation
commit: |
johnstonmatt
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults the
Databasegeneric toanyinstead ofunknownacross every client-creating function (withSupabase,withSupabaseClient,withSupabaseAdminClient,createSupabaseContext,createContextClient,createAdminClient, and both the Hono and Elysia adapters), plusSupabaseContextitself. Previously an unannotated write failed type-checking, for examplectx.supabase.from('t').insert({...})resolved tonot assignable to parameter of type 'never', forcing every untyped consumer into awithSupabase<any>(...)workaround just to compile.This matches
createClient()in@supabase/supabase-js, which has always defaulted its ownDatabasegeneric toany. Nobody loses type safety who wants it: pass generated database types the same way as before,withSupabase<Database>(...), and every table and RPC call stays fully typed. Only the unannotated path changes, from a compile error to a permissive default.The
anydefault is centralized in one named alias,UntypedDatabase, intypes.ts, rather than repeated as a bareanyat each call site. Docs (typescript-generics.md,api-reference.md,adapters/nestjs.md) are updated to match.