fix(cors): preserve network error responses - #162
Merged
mandarini merged 1 commit intoSep 15, 2026
Merged
Conversation
mandarini
approved these changes
Sep 15, 2026
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #161.
Preserve
Response.error()inaddCorsHeadersinstead of rebuilding it with status0, which throws aRangeError. Network-error responses have no HTTP headers to augment; regular HTTP responses keep the existing CORS behavior.Adds regression coverage for default/custom CORS and the public handler/pipeline forms, plus HTTP 400/500 controls that preserve status, body and CORS headers.
Verification
The PR's source matches the cross-platform/E2E-tested commit exactly. Additional validation workflow settings remain on the fork and are not part of this PR. Runtime tests ran on GitHub-hosted runners.
AI-assisted with GitHub Copilot.