fix: settle contended TUS lock waits on abort - #1345
Open
hsusul wants to merge 1 commit into
Open
Conversation
Signed-off-by: Henry Su <henrysu4707@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1344
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When PostgreSQL-backed TUS lock acquisition is waiting on a contended resource, aborting the acquisition clears both retry timers without resolving either promise. Both branches of the acquisition race can remain pending until the surrounding transaction timeout.
What is the new behavior?
Abort-aware lock waits now settle and remove their listeners on both timeout and abort. The contention backoff reuses that behavior, already-aborted signals are honored, and the outer stop-signal listener is removed when acquisition finishes.
Tests
Added a deterministic regression test that enters the ResourceLocked retry path, aborts after the release request is published, and verifies acquisition settles on the next event-loop turn.
Validated with:
Additional context
#1115 also touches this file as part of a broader database transaction refactor, but its contended retry wait retains the same abort-time pending-promise behavior.