Reject connect - #56
Merged
Merged
Conversation
Request validators check the Host header of each request, but a request tunneled through CONNECT is delivered to whatever the CONNECT line named. A client holding a secret scoped to one host could CONNECT to another host and send a tunneled request with the allowed host in its Host header, and the secret would be injected and delivered to the CONNECT target. The shipped client never uses CONNECT, so refuse it outright.
The dial guard that refuses private, loopback, and fdaa::/8 addresses was only installed when the hostnames list contained a literal IP, so a deployment configured with DNS names or nothing at all ran with no guard. Install it unconditionally. Tests that run their upstream on loopback opt out with AllowPrivateUpstreams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.