fix(tools): read text parts from OpenAI array message content - #1465
Open
su6u wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAI chat
contentcan be a string or an array of parts (text, image, etc). The middleware only treated strings as a real user message, so anything like:came through as empty.
That meant query/full skipped memory search, and
addMemory: "always"skipped saving the turn. String-only chats were fine.Same file already unwraps text parts when posting to
/v4/conversations. Vercel and VoltAgent already do this too. This just does the same for the OpenAI chat path.Test plan
packages/tools/src/openai/middleware.test.ts(string, array+image, multiple text parts, image-only, save path)No breaking changes.