Skip to content

breaking: replace edge option with runtime - #17065

Open
teemingc wants to merge 11 commits into
version-3from
teemingc-netlify-runtime-option
Open

breaking: replace edge option with runtime#17065
teemingc wants to merge 11 commits into
version-3from
teemingc-netlify-runtime-option

Conversation

@teemingc

@teemingc teemingc commented Sep 8, 2026

Copy link
Copy Markdown
Member

This PR removes the edge: true adapter option in favour of runtime: 'edge' | 'nodejs22.x' etc. This is what we did for the Vercel adapter previously. It makes sense to do this as the next PR will introduce route-level configs

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 8, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 5606a03:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/5606a03206879d63fba25d70b9c95af3b89ee6d1

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17065

@changeset-bot

changeset-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5606a03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@svelte-docs-bot

Copy link
Copy Markdown

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc teemingc changed the title breaking(adapter-netlify): replace edge option with runtime breaking: replace edge option with runtime Sep 8, 2026
@teemingc teemingc added pkg:adapter-netlify needs-platform-tests This PR needs to run platform tests in order to merge. labels Sep 8, 2026
teemingc and others added 3 commits September 8, 2026 22:58
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
teemingc and others added 4 commits September 8, 2026 23:11
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Rich-Harris

Copy link
Copy Markdown
Member

In two minds about this. It makes sense on Vercel because you can configure runtime and region independently (and runtime: 'edge' is deprecated anyway), but on Netlify an edge function is a categorically different beast — it's not just the fact that the code runs on Deno, it's that it runs at the nearest edge location. Given that, a boolean feels a bit more logical to me.

(Having said all that it's very unclear what 'edge location' means exactly — if it's white-labelled Deno Deploy, does that mean the 6 Deno Deploy Classic locations or the 2 Deno Deploy locations?)

@teemingc

teemingc commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

(Having said all that it's very unclear what 'edge location' means exactly — if it's white-labelled Deno Deploy, does that mean the 6 Deno Deploy Classic locations or the 2 Deno Deploy locations?)

Maybe @serhalp can weigh in on the specifics

@teemingc
teemingc removed this pull request from stack #17067 September 9, 2026 15:11
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github dismissed their stale review September 9, 2026 16:10

rich has some concerns to resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change needs-platform-tests This PR needs to run platform tests in order to merge. pkg:adapter-netlify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants