fix: increase streaming chunk size for CSV and Excel view downloads#1817
Open
jacalata wants to merge 1 commit into
Open
fix: increase streaming chunk size for CSV and Excel view downloads#1817jacalata wants to merge 1 commit into
jacalata wants to merge 1 commit into
Conversation
Raises iter_content chunk size from 1024 to 65536 bytes in _get_view_csv and _get_view_excel. The 1-KB default required ~200k iterations for a 200 MB download, causing apparent hangs when callers materialise the full stream with b''.join(view.csv). Closes #1374 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Should this use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iter_contentchunk size from 1024 to 65536 bytes in_get_view_csvand_get_view_excelb''.join(view.csv)Closes #1374
Test plan
test_populate_csv,test_populate_excel,test_filter_excel,test_populate_csv_default_maxageall pass🤖 Generated with Claude Code