release: add upload-mac target that clobbers unsigned darwin assets - #48
Merged
Merged
Conversation
Uploading the signed zips next to the goreleaser assets left the release with both: the signed aperture_<ver>_darwin_<arch>.zip and the unsigned aperture_darwin_<arch>.tar.gz, with checksums.txt still pointing at the unsigned tarballs, so anyone verifying a download got the unsigned build. upload-mac deletes the darwin assets on the tag's release, uploads the signed zips, then rewrites checksums.txt in place (linux lines kept, darwin lines replaced with the zip sums). -R is explicit because a checkout whose origin is the corp git proxy cannot be resolved by gh. Also fix notarize-mac writing full .build/release/ paths into the checksums file, which made shasum -c fail from any download directory; the sums now carry bare filenames. Verified in-sandbox with a stubbed gh: only the two darwin tarballs are deleted, linux assets untouched, merged checksums.txt correct, and the target aborts before any gh call when the local artifacts are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading the signed zips next to the goreleaser assets left the release
with both: the signed aperture_darwin.zip and the unsigned
aperture_darwin_.tar.gz, with checksums.txt still pointing at the
unsigned tarballs, so anyone verifying a download got the unsigned build.