Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Middlewares have no clean way to drop a task in
pre_send(#271). For example, taskiq-deduplication has to raiseDuplicateTaskErrorout ofkiq(), so callers need try/except and a losing scheduler logs a traceback every tick.This adds
SkipSendError, which a middleware can raise frompre_sendto drop the task.kiq()then:pre_sendhooks and allpost_sendhooks,If the error carries a
task_id, the returnedAsyncTaskiqTaskpoints to that task, so the caller can follow the existing task's status and result. Without one, it points to the dropped message, and waiting for its result will time out.