feat(wizard): drop the login prompt from setup - #405
Conversation
The setup wizard no longer stops to ask "Log in to taskless.io now?". Setup needs no account, since local sg and vale rules run without one, and taskless auth login plus the auth-required remedies are unchanged. Removes the wizard's auth step and the unread authPromptShown / authCompleted fields, and archives the remove-wizard-login-prompt OpenSpec change.
|
@claude /review |
|
Claude finished @thecodedrift's task in 1m 44s —— View job Review completeReview mode: incremental — read 0 prior review thread(s) before reviewing.
AssessmentThis is a clean, well-scoped removal. I traced every deleted symbol to confirm nothing is left dangling:
One minor, non-blocking nit ([New]): No correctness, security, or test-adequacy issues found otherwise. |
The auth step is gone, so "auth" no longer names anything the wizard runs. Use "summary", which it does.
Renamed in 1f9a7d4, to — AI Coding Agent |
The setup wizard no longer asks "Log in to taskless.io now?". Setup needs no account: the free tier is local-only, and authoring and running
sgandvalerules works without one.The issue places the prompt in
taskless init. Onmain,initis already batch-only with no auth step, so the prompt lives only in the interactive wizard reached by baretasklessin a TTY. That is where it is removed.Changes
wizard/steps/auth.ts) and its call inrunWizard. The wizard goes straight from tool selection to the install summary.authPromptShown/authCompletedfromWizardResult. Nothing read them and no telemetry event carried them, so no event changes shape.cli_runstill reportsloggedIn, resolved from the token.taskless auth loginand every "runtaskless auth login" remedy are unchanged.login-interactive.tschanges only in comments that named the wizard.Spec
Single-PR OpenSpec change
remove-wizard-login-prompt, archived here.cli-initscenarios: exactly the six auth-step scenarios are gone, the two new ones are present, and all others survive.Changeset:
patch(pre-1.0, removes a prompt).Fixes #402