Pickup API proto support for NexusHandler callbacks - #317
Merged
Merged
Conversation
chrsmith
commented
Sep 9, 2026
| wantPayloadCount int | ||
| }{ | ||
| {"temporal.api.update.v1.Rejection", 7}, | ||
| {"temporal.api.update.v1.Rejection", 8}, |
Contributor
Author
There was a problem hiding this comment.
This is the only change created by hand. (Everything else was updating the proto/api submodule, and rerunning make.)
This is the test failure without this change:
Error: Not equal:
expected: 7
actual : 8
Test: TestVisitedPayloads/temporal.api.update.v1.Rejection
Messages: expected 7 payloads reachable from temporal.api.update.v1.Rejection, found 8
temporal.api.update.v1.Rejection: 51 messages visited, 8 payloads seen
payloads seen:
1. temporal.api.update.v1.Rejection.rejected_request.input.header.fields [temporal.api.common.v1.Payload]
2. temporal.api.update.v1.Rejection.rejected_request.input.args [temporal.api.common.v1.Payloads]
3. temporal.api.update.v1.Rejection.rejected_request.completion_callbacks.nexus_handler.source_context [temporal.api.common.v1.Payload]
4. temporal.api.update.v1.Rejection.failure.encoded_attributes [temporal.api.common.v1.Payload]
5. temporal.api.update.v1.Rejection.failure.application_failure_info.details [temporal.api.common.v1.Payloads]
6. temporal.api.update.v1.Rejection.failure.timeout_failure_info.last_heartbeat_details [temporal.api.common.v1.Payloads]
7. temporal.api.update.v1.Rejection.failure.canceled_failure_info.details [temporal.api.common.v1.Payloads]
8. temporal.api.update.v1.Rejection.failure.reset_workflow_failure_info.last_heartbeat_details [temporal.api.common.v1.Payloads]
And (8) is the newly referenced commonpb.Payload, referenced from the newly added temporal.api.update.v1.Rejection.rejected_request.completion_callbacks.nexus_handler.source_context (commonpb.Callback_NexusHandler type).
chrsmith
force-pushed
the
feature/worker-callbacks
branch
from
September 9, 2026 02:19
0fa022a to
ac257d4
Compare
VegetarianOrc
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR updates the
api-gorepo to pickup the latest version ofapi, to bring in temporalio/api#863.Why?
Because temporalio/api#863 includes the super-duper awesome
NexusHandler-variant callback type, of course! And by committing a version ofapi-gowith it, the server-side changes can pickup the new types.How did you test it?
I ran
make test.Potential risks
None that I am aware of.