Skip to content

[CLDAPP-423] Add Encryption Validation - #113

Draft
daehan-temporal wants to merge 1 commit into
mainfrom
daehan/eve
Draft

daehan-temporal wants to merge 1 commit into
mainfrom
daehan/eve

Conversation

@daehan-temporal

@daehan-temporal daehan-temporal commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What was changed

Adds Cloud CLI support for namespace payload encryption validation (EVE):

temporal cloud namespace encryption-validation get|set|enable|disable

namespace create also accepts optional --encryption-validation-* flags. If any of those flags is set, --encryption-validation-mode is required.

  • set replaces the whole nested spec. Omitted optional flags are sent as empty/false.
  • enable turns validation on. Unconfigured namespaces get defaults (warn / encoding / binary/encrypted). Disabled namespaces are re-enabled and keep metadata/inspect. Already-warn or already-deny is left unchanged. --deny only applies when turning validation on.
  • disable sets mode to disabled and keeps metadata/inspect.

Pins go.temporal.io/cloud-sdk to v0.18.1-0.20260915065746-d48c11f885cb (v0.18.0 plus EncryptionValidation). Temporarily sends APIVersion: development because staging still gates this field.

Why?

Give customers a CLI to inspect and change namespace encryption-validation settings, with enable/disable for the common on/off path and set as an explicit replace.

Checklist

  1. Closes - CLDAPP-423

  2. How was this tested:

go test ./temporalcloudcli -run 'TestCreateNamespace_|TestNamespaceDescription|TestNamespaceEncryptionValidation'
  1. Any docs updates needed?
    https://docs.temporal.io/cli/command-reference/cloud/namespace

Note

Medium Risk
Changes namespace security-related settings and forces a development API version on all Cloud clients until the gate is removed; misconfiguration in deny mode could block workflows.

Overview
Adds namespace payload encryption validation to the Temporal Cloud CLI, including a new encryption-validation command group with get, set, enable, and disable. Set fully replaces the nested spec (omitted flags become empty/false); enable applies sensible defaults or re-enables disabled config while preserving metadata; disable only sets mode to disabled.

namespace create now accepts optional --encryption-validation-* flags; if any are set, --encryption-validation-mode is required. The CLI pins go.temporal.io/cloud-sdk to a pre-release that exposes EncryptionValidation, and BuildCloudClient temporarily sends APIVersion: development so staging can use the new API. The --api-key flag help no longer mentions TEMPORAL_API_KEY.

Reviewed by Cursor Bugbot for commit 8dd25b5. Bugbot is set up for automated code reviews on this repo. Configure here.

@daehan-temporal daehan-temporal self-assigned this Sep 15, 2026
@daehan-temporal
daehan-temporal requested a review from a team as a code owner September 15, 2026 07:17
@daehan-temporal
daehan-temporal marked this pull request as draft September 15, 2026 07:17

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8dd25b5. Configure here.

if spec.Mode == namespacev1.EncryptionValidationSpec_ENCRYPTION_VALIDATION_MODE_DISABLED {
spec.Mode = mode
}
return spec

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable skips defaults after disable

Medium Severity

enable applies encoding / binary/encrypted defaults only when EncryptionValidation is nil. disable on an unconfigured namespace writes a disabled spec with empty metadata, so a later enable turns validation on without those defaults. The resulting warn/deny config has no metadata key or values, so payload identification does not match the documented enable path.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8dd25b5. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant