Restore SDK ownership of Nexus samples - #523
Merged
Merged
Conversation
mjameswh
commented
Sep 16, 2026
tconley1428
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PR #517 added a Nexus-only CODEOWNERS rule for
/nexus*/.Because later matches replace the default owner set, that rule prevents an SDK-team approval from satisfying repository-wide maintenance changes such as PR #522.
Make the SDK and Nexus teams co-owners of Nexus sample directories. This preserves Nexus review coverage while keeping the SDK team able to maintain the complete samples repository, consistent with the existing AI sample rules.
Validation:
git diff --check passes@temporalio/sdk