docs: confirm OLED I2C address against real hardware - #52
Merged
Merged
Conversation
Printed on the display module's own silkscreen, matching what was already assumed (and what PCB/GPIO_table.md already documented as fact) — no code change, just removing the now-stale "unconfirmed assumption" hedge. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main. This re-lands just that one commit on top of currentmain.include/oled.h's comment, since0x3Cis confirmed printed on the display module's own silkscreen (and already documented as fact inPCB/GPIO_table.md).Test plan
pio run -e esp32s3still builds clean.🤖 Generated with Claude Code