feat: stick-as-nav, configurable deadzone, and menu bug fixes from hardware bring-up

[thePunderWoman]

Summary

Continued hands-on testing of the on-device menu turned up several real bugs and one missing feature:

• Left/Right button mapping was backwards — Buttons::kLeftUp/kLeftDown and kRightUp/kRightDown were mapped to the physically wrong pairs (Vol/Trigger swapped). Confirmed against the real controller and fixed; nothing else hardcodes the physical mapping, so this one change fixes it everywhere (menu-open combo, uplink suppression, Button Test display).
• Calibration now confirms with Macro1, not Stick Click — clicking the stick itself risks nudging its position right as center/extremes are being captured, and there's no button actually labeled "Enter" on this controller.
• Droid-naming screen fixes — it had zero on-screen instructions, and Bumper used to backspace one character at a time before actually leaving (looked broken unless you'd already cleared everything you'd typed). Added instructions; Bumper now always exits immediately, matching every other screen.
• Thumbstick as menu navigation — an alternative to the Left Up/Down buttons everywhere nav applies, with fire/rearm thresholds so holding it doesn't spam-scroll. Tuned down from 60% to 25% after real hardware testing showed 60 wasn't reliably reachable in every direction even at full push.
• Stick calibration safety gate — confirmDone() now refuses to finish unless all four extremes are at least 300 raw ADC counts from center. Confirming too early was silently saving a near-zero range, which made ordinary ADC noise read as huge stick movement (this is the bug behind today's "cursor won't stop scrolling" report). Rolling-step instructions rewritten to be explicit ("Rotate stick all the way around 3 times, return to center, then press Macro1").
• Configurable stick deadzone — new "Stick Deadzone" menu screen, presets 0/3/5/8/12/15/20%, persisted alongside the rest of calibration. Previously a fixed 3% baked into the code.
• Systemic redraw bug, fixed properly — the display only redrew when the current screen or main-menu selection changed, so any in-place change that didn't also switch screens (list scrolling, text-entry letters, calibration step progress, Display/Power Config value cycling, the new Stick Deadzone value) silently never appeared after a screen's first render. This is the root cause behind several "button doesn't seem to do anything" reports today (droid-name letters not updating, Power/Display Config cursor not moving). Fixed by having MenuController::tick() report whether it fired a nav event and redrawing whenever any menu-mutating call happens, rather than continuing to enumerate individual per-screen fields — this had already slipped through once before (Button Test's last-pressed-button field).

Test plan

• pio test -e native — 284/284 passing
• pio run -e esp32s3 — builds clean
• All fixes verified against real hardware this session: stick-up navigation, Display Config and Power Config cursor movement, droid-name letter scrolling, and the calibration safety gate all confirmed working after the fixes

🤖 Generated with Claude Code