audio: eq_iir: register IPC-time blob validator#10942
Open
singalsu wants to merge 2 commits into
Open
Conversation
lyakh
reviewed
Jun 19, 2026
| } | ||
| if (lookup) { | ||
| for (; i < SOF_EQ_IIR_MAX_RESPONSES; i++) | ||
| lookup[i] = NULL; |
Collaborator
Author
There was a problem hiding this comment.
Yep, and the memset can be before the loop.
| return -EINVAL; | ||
| } | ||
|
|
||
| return 0; |
Collaborator
There was a problem hiding this comment.
you never propagate this function's returned error code and always use it as a condition in if clauses. How about making it boolean
static bool eq_iir_blob_size_valid(struct comp_dev *dev, size_t size)
{
return size >= sizeof(struct sof_eq_iir_config) && size <= SOF_EQ_IIR_MAX_SIZE;
}
Collaborator
Author
There was a problem hiding this comment.
OK, I'll change to this.
Hook an eq_iir blob validator into the model handler so a corrupted run-time configuration update is rejected before it can replace the working blob. Playback or capture then continues with the previously set coefficients instead of being interrupted by a bad IPC. The validator parses the blob layout end to end: the size envelope, channel and response counts, each response header and biquad section bounds, and the assign_response[] entries reachable by the per-channel loop. The layout walk is factored into a shared helper that eq_iir_init_coef() also reuses at setup time, so IPC-time and prepare-time agree on structural validity; the assign_response[] check is exclusive to the IPC path, where the full table must be validated without knowing the stream channel count. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
model_handler_validator_eqiir
branch
from
db4e659 to
442b1d4
Compare
Use memset() to zero the unused tail of the response lookup array in eq_iir_walk_config() instead of a per-slot loop. The walk pre-clears the whole table once when a lookup is requested and then fills the in-use entries. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an IPC-time configuration blob validator for the EQ IIR component so malformed coefficient updates are rejected before they can replace a working runtime configuration. It aligns EQ IIR behavior with existing components (e.g., EQ FIR) that install a blob validator during prepare() and clear it on reset().
Changes:
- Introduces
eq_iir_validate_config()and exposes it viaeq_iir.h. - Refactors EQ IIR blob parsing to share a common structural validation walk (
eq_iir_walk_config()). - Registers the validator in
eq_iir_prepare()(and unregisters ineq_iir_reset()), removing the redundant run-time blob size check in the audio processing path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/audio/eq_iir/eq_iir.h | Declares the new eq_iir_validate_config() entry point used for IPC-time validation. |
| src/audio/eq_iir/eq_iir.c | Uses the validator in prepare(), registers/unregisters it, and simplifies the run-time update path. |
| src/audio/eq_iir/eq_iir_generic.c | Implements structural blob validation and assign-response validation, reusing shared parsing logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.