audio: drc: register IPC-time blob validator#10943
Open
singalsu wants to merge 1 commit into
Open
Conversation
lyakh
reviewed
Jun 19, 2026
| if (ret < 0) | ||
| return ret; | ||
|
|
||
| if (config->size != new_data_size) { |
Collaborator
There was a problem hiding this comment.
not sure why 2 functions are needed, can we just make it a simple check if (new_data_size != sizeof(struct sof_drc_config) || new_data_size != config->size)?
Collaborator
Author
There was a problem hiding this comment.
Yep, you are right. It makes sense to combine them.
Hook a drc blob validator into the model handler so a corrupted run-time configuration update is rejected before it can replace the working blob. Playback or capture then continues with the previously set parameters instead of being interrupted by a bad IPC. The DRC configuration is a fixed-size struct sof_drc_config, so the validator requires the IPC payload size to match exactly and the self-declared config->size to agree with it. The same size check is also reused at prepare time when the initial blob is fetched. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
model_handler_validator_drc
branch
from
20c85b6 to
e0ff5f6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an IPC-time validator for the DRC configuration blob so malformed run-time updates are rejected before they can replace the currently active configuration, and reuses the same validation at prepare() time when initially loading the blob.
Changes:
- Introduce a
drc_validator()that enforces exact payload size matchingstruct sof_drc_configand verifiesconfig->sizeconsistency. - Apply the validator to the initial configuration fetch in
drc_prepare(). - Register/unregister the validator on the data-blob handler in
drc_prepare()/drc_reset()to prevent corrupted IPC updates from being accepted during streaming.
Comment on lines
394
to
397
| } else { | ||
| /* Generic function for all formats */ | ||
| cd->drc_func = drc_default_pass; | ||
| } |
Comment on lines
+146
to
+151
| if (new_data_size != sizeof(struct sof_drc_config) || | ||
| new_data_size != config->size) { | ||
| comp_err(dev, "invalid configuration blob, size %u, expected %zu", | ||
| new_data_size, sizeof(struct sof_drc_config)); | ||
| return -EINVAL; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hook a drc blob validator into the model handler so a corrupted run-time configuration update is rejected before it can replace the working blob. Playback or capture then continues with the previously set parameters instead of being interrupted by a bad IPC.
The DRC configuration is a fixed-size struct sof_drc_config, so the validator requires the IPC payload size to match exactly and the self-declared config->size to agree with it. The same size check is also reused at prepare time when the initial blob is fetched.