Alias namespaced keyword in custom hiccup element leads to error "failed to parse ns"

[thetenter]

After happily using shadow-css for some time I think I found an unreported bug.
Thank you so much for this great library. For me it is by far the best css story for clojure.

Context

• I'm using alias namespaced keywords for custom hiccup elements with the chassis library

Problem

• If at least one custom hiccup element with alias namespaced keyword, e.g. [::my-alias/my-component] is part of a namespace used with shadow-css build process, the following error is thrown: failed to parse ns

Reproduction steps

1. Build css with shadow-css build process including at least one namespace with at least one alias namespaced keyword as custom hiccup element.

Example:

(ns planning-assistant.ui.components.my-component
  (:require
   [shadow.css :refer (css)]
   [planning-assistant.ui.components.checkbox :as checkbox]))

(def hiccup-using-namespaced-alias-keyword
  [::checkbox/checkbox])

Observed

• Following error is thrown:

----- Error --------------------------------------------------------------------
Type:     clojure.lang.ExceptionInfo
Message:  failed to parse ns
Data:     {:ns planning-assistant.ui.components.my-component}
Location: shadow/css/analyzer.cljc:379:19

----- Context ------------------------------------------------------------------
375: 
376:               (try
377:                 (reader/read {:eof eof :read-cond :preserve} reader)
378:                 (catch #?(:clj Exception :cljs :default) e
379:                   (throw (ex-info "failed to parse ns" {:ns (:ns state)} e)))))]
                       ^--- failed to parse ns
380: 
381:         (if (identical? form eof)
382:           state
383: 
384:           (let [next-state (find-css-calls state form)]

----- Stack trace --------------------------------------------------------------
shadow.css.analyzer/find-css-in-source    - shadow/css/analyzer.cljc:379:19
shadow.css.analyzer/find-css-in-source    - shadow/css/analyzer.cljc:376:15
shadow.css.analyzer/find-css-in-source    - shadow/css/analyzer.cljc:345:1
shadow.css.build/index-source             - shadow/css/build.cljc:342:9
shadow.css.build/index-source             - shadow/css/build.cljc:340:1
... (run with --debug to see elided elements)
user-0b6ae10c-cd43-4eaf-afac-2bfbd32d76dd - <expr>:26:92
shadow.css.build/generate                 - shadow/css/build.cljc:282:1
user-0b6ae10c-cd43-4eaf-afac-2bfbd32d76dd - <expr>:26:162
shadow.css.build/write-outputs-to         - shadow/css/build.cljc:528:8
user-0b6ae10c-cd43-4eaf-afac-2bfbd32d76dd - <expr>:26:225

Expected

• No error is thrown.

Demarcation

• The same example with namespaced keyword as custom hiccup element (without alias) works.

(ns planning-assistant.ui.components.my-component
  (:require
   [shadow.css :refer (css)]
   [planning-assistant.ui.components.checkbox :as checkbox]))

(def hiccup-using-namespaced-alias-keyword
  [:planning-assistant.ui.components.checkbox/checkbox])

[thheller]

This is missing the exception that actually caused the failed parse? There should be a "Caused by: ..." in the stacktrace? I use namespaced keywords all over the place, so dunno why this would fail? I can't reproduce it with just the provided snippet?

[thetenter]

Unfortunately there is no "Caused by: ..." in the stacktrace.
Your input that you are using namespaced keywords all over the place made me wonder if me using babashka could be the problem.

Further localization of the problem:

• Using clj -T:build css-release with the following css-release fn in build.clj in the project root dir works.

(defn css-release [& args]
  (let [build-state
        (-> (css.build/start)
            (dissoc :preflight-src)
            (css.build/index-path (io/file "src" "main" "planning_assistant") {})
            (css.build/generate
             '{:ui {:include [planning-assistant.*]}})
            #_(css.build/minify)
            (css.build/write-outputs-to (io/file "resources" "public" "css")))]
    (doseq [mod                                 (vals (:chunks build-state))
            {:keys [warning-type]
             :as   warning} (:warnings mod)]
      (prn [:CSS (name warning-type) (dissoc warning :warning-type)]))))

• Using bb css with the following bb.edn file in the project root dir does not work and throws the error bellow in the terminal.

{:paths ["."]
 :deps  {com.thheller/shadow-css {:mvn/version "0.6.1"}}
 :tasks {:requires ([clojure.java.io :as io]
                    [shadow.css.build :as css.build])
         css       (let [build-state
                         (-> (css.build/start)
                             (dissoc :preflight-src)
                             (css.build/index-path (io/file "src" "main" "planning_assistant") {})
                             (css.build/generate
                              '{:ui {:include [planning-assistant.*]}})
                             #_(css.build/minify)
                             (css.build/write-outputs-to (io/file "resources" "public" "css")))]
                     (doseq [mod                                 (vals (:chunks build-state))
                             {:keys [warning-type]
                              :as   warning} (:warnings mod)]
                       (prn [:CSS (name warning-type) (dissoc warning :warning-type)])))}}

$ bb css
----- Error --------------------------------------------------------------------
Type:     clojure.lang.ExceptionInfo
Message:  failed to parse ns
Data:     {:ns planning-assistant.ui.components.my-component}
Location: shadow/css/analyzer.cljc:379:19

----- Context ------------------------------------------------------------------
375: 
376:               (try
377:                 (reader/read {:eof eof :read-cond :preserve} reader)
378:                 (catch #?(:clj Exception :cljs :default) e
379:                   (throw (ex-info "failed to parse ns" {:ns (:ns state)} e)))))]
                       ^--- failed to parse ns
380: 
381:         (if (identical? form eof)
382:           state
383: 
384:           (let [next-state (find-css-calls state form)]

----- Stack trace --------------------------------------------------------------
shadow.css.analyzer/find-css-in-source    - shadow/css/analyzer.cljc:379:19
shadow.css.analyzer/find-css-in-source    - shadow/css/analyzer.cljc:376:15
shadow.css.analyzer/find-css-in-source    - shadow/css/analyzer.cljc:345:1
shadow.css.build/index-source             - shadow/css/build.cljc:342:9
shadow.css.build/index-source             - shadow/css/build.cljc:340:1
... (run with --debug to see elided elements)
user-05b29be4-d954-41c0-8fda-d394729ea6a4 - <expr>:26:65
shadow.css.build/generate                 - shadow/css/build.cljc:282:1
user-05b29be4-d954-41c0-8fda-d394729ea6a4 - <expr>:26:135
shadow.css.build/write-outputs-to         - shadow/css/build.cljc:528:8
user-05b29be4-d954-41c0-8fda-d394729ea6a4 - <expr>:26:198

[thheller]

I have never tried this with babashka, so no clue what the issue might be.

[thetenter]

Should I close the issue because this library never claimed to be compatible with babashka or would you rather keep it open in case babashka support will be a future goal?

Thanks again for your time and the great library.

[thheller]

I'd still be curious to know whats wrong and whether its worth adressing on the shadow.css side. Just no time to dig into the babashka side of things currently. Fine with me to leave this open, but no clue when I'll find time to look at it.