Skip to content

[Automated] Update eksctl CLI Options - #4618

Open
thomhurst wants to merge 1 commit into
mainfrom
automated/update-cli-options-eksctl
Open

[Automated] Update eksctl CLI Options#4618
thomhurst wants to merge 1 commit into
mainfrom
automated/update-cli-options-eksctl

Conversation

@thomhurst

@thomhurst thomhurst commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

This PR contains automatically generated updates to eksctl CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Assembly-wide public API impact

Affected API families: Eksctl.

  • Added APIs: 14
  • Removed or changed APIs: 14
  • Members with matching names but changed signatures: 0

Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.

Representative removed or changed members:

  • ModularPipelines.Eksctl.Enums.EksctlCreateCapabilityType.Argocd = 2 -> ModularPipelines.Eksctl.Enums.EksctlCreateCapabilityType
  • ModularPipelines.Eksctl.Enums.EksctlCreateCapabilityType.Kro = 1 -> ModularPipelines.Eksctl.Enums.EksctlCreateCapabilityType
  • ModularPipelines.Eksctl.Enums.EksctlUpdateCapabilityType.Argocd = 2 -> ModularPipelines.Eksctl.Enums.EksctlUpdateCapabilityType
  • ModularPipelines.Eksctl.Enums.EksctlUpdateCapabilityType.Kro = 1 -> ModularPipelines.Eksctl.Enums.EksctlUpdateCapabilityType
  • ModularPipelines.Eksctl.Enums.EksctlUtilsUpdateClusterLoggingDisableTypes.Api = 2 -> ModularPipelines.Eksctl.Enums.EksctlUtilsUpdateClusterLoggingDisableTypes

Representative added members:

  • ModularPipelines.Eksctl.Enums.EksctlCreateCapabilityType.Argocd = 1 -> ModularPipelines.Eksctl.Enums.EksctlCreateCapabilityType
  • ModularPipelines.Eksctl.Enums.EksctlCreateCapabilityType.Kro = 2 -> ModularPipelines.Eksctl.Enums.EksctlCreateCapabilityType
  • ModularPipelines.Eksctl.Enums.EksctlUpdateCapabilityType.Argocd = 1 -> ModularPipelines.Eksctl.Enums.EksctlUpdateCapabilityType
  • ModularPipelines.Eksctl.Enums.EksctlUpdateCapabilityType.Kro = 2 -> ModularPipelines.Eksctl.Enums.EksctlUpdateCapabilityType
  • ModularPipelines.Eksctl.Enums.EksctlUtilsUpdateClusterLoggingDisableTypes.Api = 1 -> ModularPipelines.Eksctl.Enums.EksctlUtilsUpdateClusterLoggingDisableTypes

Command coverage

Command coverage report:

  • eksctl (0.230.0): 85 commands, tree 84fec058d6a4a16c205233e11b13a4ffb48fce85b9cb074d731bba5dc937d7a5
    • Baseline comparison: 85 commands at 0.230.0 -> 85 commands at 0.230.0

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • src/ModularPipelines.Eksctl/Generated/Eksctl.Generation.json is excluded by !**/generated/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: dd514059-af8f-46b1-b510-928c768a1798

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 955912ed-7520-4b54-b4f1-77ff5beb66dc

📥 Commits

Reviewing files that changed from the base of the PR and between 49f5b9b and 82e728e.

⛔ Files ignored due to path filters (8)
  • src/ModularPipelines.Eksctl/Enums/EksctlCreateCapabilityType.Generated.cs is excluded by !**/*.generated.*
  • src/ModularPipelines.Eksctl/Enums/EksctlUpdateCapabilityType.Generated.cs is excluded by !**/*.generated.*
  • src/ModularPipelines.Eksctl/Enums/EksctlUtilsUpdateClusterLoggingDisableTypes.Generated.cs is excluded by !**/*.generated.*
  • src/ModularPipelines.Eksctl/Enums/EksctlUtilsUpdateClusterLoggingEnableTypes.Generated.cs is excluded by !**/*.generated.*
  • src/ModularPipelines.Eksctl/Generated/Eksctl.Generation.json is excluded by !**/generated/**
  • src/ModularPipelines.Eksctl/Options/EksctlSetOptions.Generated.cs is excluded by !**/*.generated.*
  • src/ModularPipelines.Eksctl/Services/EksctlSet.Generated.cs is excluded by !**/*.generated.*
  • src/ModularPipelines.Eksctl/Services/IEksctlSet.Generated.cs is excluded by !**/*.generated.*
📒 Files selected for processing (2)
  • src/ModularPipelines.Eksctl/PublicAPI.Shipped.txt
  • src/ModularPipelines.Eksctl/PublicAPI.Unshipped.txt
💤 Files with no reviewable changes (1)
  • src/ModularPipelines.Eksctl/PublicAPI.Shipped.txt

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The PR updates eksctl public API tracking. It removes obsolete shipped enum members and corrects unshipped enum values and the ControllerManager member name.

Changes

eksctl API updates

Layer / File(s) Summary
Update shipped enum surface
src/ModularPipelines.Eksctl/PublicAPI.Shipped.txt
Removes obsolete capability and cluster logging enum members from the shipped API declarations.
Correct unshipped enum declarations
src/ModularPipelines.Eksctl/PublicAPI.Unshipped.txt
Re-adds capability members with swapped values. Renumbers cluster logging members and renames Controllermanager to ControllerManager.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 82e72

This updates eksctl capability and cluster-logging enum API metadata to the corrected values and names. The current changes align with the generated declarations and are ready to merge.

Poem

A rabbit checks each enum line
Argocd and Kro now align
Logging names hop into place
Values follow a clearer trace
The API garden grows precise

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies an automated update to the eksctl CLI options, which matches the pull request objectives and changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch automated/update-cli-options-eksctl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thomhurst
thomhurst force-pushed the automated/update-cli-options-eksctl branch from 73fc27e to 6afa1f6 Compare September 6, 2026 06:28
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review: [Automated] Update eksctl CLI Options (#4618)

This is a fully auto-generated, mechanical PR from ModularPipelines.OptionsGenerator — no hand-written code is touched.

What it does:

  • Bumps generatorSourceSha256 in Eksctl.Generation.json to reflect the recent generator refactor (the shared wrapped-description helper landed on main in Port the remaining nine CLI scrapers onto the shared wrapped-description helper #4658).
  • Adds the previously-missing class-level <summary> doc ("Set values") to EksctlSetOptions, and replaces the generic placeholder "Executes the parent command directly." with the real description ("Set values") on EksctlSet.ExecuteAsync / IEksctlSet.ExecuteAsync.

Verification: I cross-checked this against sibling parent-group commands that already have descriptions wired up correctly — EksctlCreateOptions/IEksctlCreate ("Create resource(s)") and EksctlUtilsOptions/IEksctlUtils ("Various utils") both already carry this exact same class-summary + ExecuteAsync-summary pattern on main. So this PR isn't introducing a new convention — it's just catching the set group up to a pattern its siblings already follow, closing a gap left before the generator fix. The diff is minimal, correctly scoped, and matches the repo's rule that generated-output fixes must come from the scraper/generator rather than hand-edits (this is exactly that: purely regenerated output, no manual tweaks).

No design, architecture, or maintainability concerns here — there's no handwritten logic to critique in a doc-string regeneration.

One thing worth a human look before merging: several CI checks are currently red — Fast fail, analyzers, generated integration (ModularPipelines.Eksctl), trim and Native AOT, and pipeline (ubuntu-latest). Given the change is only a hash bump plus three added/edited XML doc comments, it's hard to see how it could cause a trim/AOT or general pipeline failure — this looks more likely to be Fast fail gating/cascading into the rest of the matrix, or an unrelated pre-existing/environmental issue on main, rather than something caused by this diff. I wasn't able to pull the raw job logs in this environment to confirm root cause, so please check the Fast fail log before merging to rule out a real regression.

@thomhurst
thomhurst force-pushed the automated/update-cli-options-eksctl branch from 6afa1f6 to fca5b0f Compare September 6, 2026 07:58
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review: [Automated] Update eksctl CLI Options (#4618)

This is a mechanical, fully auto-generated PR from ModularPipelines.OptionsGenerator — no hand-written code is touched, consistent with the repo's convention that generated-options fixes must originate in the scraper/generator rather than as manual edits.

What changed:

  • EksctlCreateCapabilityType, EksctlUpdateCapabilityType, EksctlUtilsUpdateClusterLoggingDisableTypes, EksctlUtilsUpdateClusterLoggingEnableTypes: enum members reordered (now alphabetical: Argocd before Kro; None moved after ControllerManager). This is a source-breaking but not binary-compatible-safe change for consumers who reference members by name (fine) but changes underlying ordinal values — correctly reflected as removed+added entries across PublicAPI.Shipped.txt / PublicAPI.Unshipped.txt.
  • EksctlSetOptions / EksctlSet.ExecuteAsync / IEksctlSet.ExecuteAsync gain a real "Set values" XML doc summary, replacing the generic "Executes the parent command directly." placeholder — bringing this parent-group command in line with sibling patterns already on main (e.g. EksctlCreateOptions, EksctlUtilsOptions).
  • generatorSourceSha256 bump in Eksctl.Generation.json reflects the regenerated output.

Verification:

  • The PublicAPI.Shipped.txt/Unshipped.txt changes are internally consistent: every enum member removed from Shipped has a matching *REMOVED* entry in Unshipped, and the newly-ordered members are added back with correct new ordinal values. No orphaned or mismatched entries.
  • The prior review on this PR flagged several red CI checks (Fast fail, analyzers, generated integration, trim and Native AOT, pipeline (ubuntu-latest)) as needing a human look before merge. As of this review, Fast fail is green and the rest of the matrix (analyzers, full pipeline, trim/AOT, build matrix) is queued/in-progress on the current head — no indication of a real regression tied to this diff, which touches only enum ordering and doc comments.

No design, architecture, or maintainability concerns — there's no handwritten logic to critique in a regenerated-options PR, and the diff is minimal and correctly scoped to the generator's output.

@thomhurst
thomhurst force-pushed the automated/update-cli-options-eksctl branch from fca5b0f to 0a22d48 Compare September 6, 2026 09:07
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review: [Automated] Update eksctl CLI Options (#4618)

This is a fully mechanical, auto-generated PR from ModularPipelines.OptionsGenerator — no hand-written code is touched. Changes are confined to src/ModularPipelines.Eksctl/:

  • Four Enums/*.Generated.cs files — enum members reordered alphabetically (e.g. Ack, Argocd, Kro), which reassigns underlying int values. This is a source-of-truth-driven change; per this repo's CLAUDE.md, "current tool output is the sole source of truth for generated options, even when regeneration causes breaking API changes."
  • Generated/Eksctl.Generation.jsongeneratorSourceSha256 bump only.
  • Options/EksctlSetOptions.Generated.cs, Services/EksctlSet.Generated.cs, Services/IEksctlSet.Generated.cs — adds the previously-missing XML doc summary ("Set values") for the eksctl set subcommand, replacing a generic placeholder. This matches the same class-summary + ExecuteAsync-summary pattern already present on sibling parent-group commands (EksctlCreateOptions, EksctlUtilsOptions), so it's not introducing a new convention.
  • PublicAPI.Shipped.txt / PublicAPI.Unshipped.txt — mechanically updated to reflect the enum renumbering, consistent with the Roslyn PublicAPI analyzer format.

Verification:

  • Grepped the repo (including the scraper tests and EksctlOptionsTests.cs) for hand-written code depending on the numeric/ordinal value or ordering of the four reordered enums — none found; only type references exist, which are unaffected by member reordering.
  • Confirmed no generated file was hand-tweaked and [ExcludeFromCodeCoverage] is retained throughout.
  • A previous review on this PR flagged that several CI checks were red (Fast fail, analyzers, trim and Native AOT, generated integration, pipeline). All checks are now green (Fast fail, Analyze x3, analyzers, build (windows-latest), trim and Native AOT, CodeFactor, CodeRabbit, Snyk all report SUCCESS), so that concern has been resolved.

No design, architecture, or maintainability concerns — there's no handwritten logic to critique in a mechanical regeneration PR. Looks good to merge.

@thomhurst
thomhurst enabled auto-merge (squash) September 6, 2026 09:51
@thomhurst
thomhurst disabled auto-merge September 6, 2026 14:12
@thomhurst
thomhurst force-pushed the automated/update-cli-options-eksctl branch from 0a22d48 to 82e728e Compare September 6, 2026 14:13
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review: Eksctl generated-options regeneration

This PR is a purely mechanical regeneration of the eksctl CLI options in src/ModularPipelines.Eksctl/, confined to .Generated.cs files and PublicAPI.Shipped.txt/PublicAPI.Unshipped.txt.

What changed:

  • Enum members in EksctlCreateCapabilityType, EksctlUpdateCapabilityType, EksctlUtilsUpdateClusterLoggingDisableTypes, and EksctlUtilsUpdateClusterLoggingEnableTypes were renumbered so they're emitted in alphabetical order by their [EnumValue("...")] string — verified each new ordering is alphabetical.
  • A doc-comment fix on the Set command ("Executes the parent command directly.""Set values"), applied consistently across IEksctlSet.Generated.cs, EksctlSet.Generated.cs, and EksctlSetOptions.Generated.cs.
  • PublicAPI.Shipped.txt/PublicAPI.Unshipped.txt updated with matching removed/added entries for the renumbered enum values.

Verification:

  • The enum renumbering is a binary-breaking change (values shift), but per CLAUDE.md: "Current tool output is the sole source of truth for generated options, even when regeneration causes breaking API changes." This is expected and correct — not a defect.
  • Checked test/ModularPipelines.Eksctl.UnitTests/ and other usages: all references to the affected enums are by member name, never raw numeric value, so no call sites break.
  • All touched files retain [ExcludeFromCodeCoverage]/[GeneratedCode] markers and no hand-edits appear outside the generator's own output, consistent with the "never hand-tweak auto-generated options" rule.

No correctness bugs, design concerns, or CLAUDE.md violations found. Looks good to merge.

@thomhurst
thomhurst force-pushed the automated/update-cli-options-eksctl branch from 82e728e to a793e67 Compare September 7, 2026 15:52
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review: eksctl generated options update (#4618)

This is an automated regeneration of ModularPipelines.Eksctl from the OptionsGenerator. I compared the generated output against the tool metadata and existing conventions:

  • No CLI behavior change: commandTreeSha256 in Eksctl.Generation.json is unchanged and the command count stays at 85; only generatorSourceSha256 changed, so this reflects a prior generator fix being applied, not new eksctl CLI surface.
  • Generated-only diff: every touched file is a *.Generated.cs, PublicAPI.Shipped.txt/Unshipped.txt, or the generation manifest — consistent with the repo rule to never hand-edit generated options.
  • Enum reordering is safe: EksctlCreateCapabilityType, EksctlUpdateCapabilityType, and the EksctlUtilsUpdateClusterLogging*Types enums were reordered alphabetically, shifting numeric ordinals. All in-repo usages (option assignment and EksctlOptionsTests) reference members by name, and the actual string sent to the eksctl CLI comes from each member's [EnumValue("...")] attribute rather than its ordinal, so this reordering has no runtime effect.
  • PublicAPI churn matches existing convention: the remove/re-add pattern with *REMOVED* markers in Shipped/Unshipped mirrors what's already present elsewhere in the baseline for this project.
  • Doc comment addition: EksctlSetOptions/EksctlSet/IEksctlSet gained a consistent "Set values" XML summary across the generated class and interface, with no signature or duplicate-member issues.

No previous review comments (CodeRabbit) flagged any actionable issues either, and I didn't find any correctness, design, or maintainability concerns to add. This is a clean, mechanical regeneration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant