[Automated] Update minikube CLI Options - #4676
Conversation
thomhurst
added
automated
dependencies
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe change updates Minikube public API tracking. It removes enum members from the shipped API file, removes their removal markers from the unshipped API file, and records new numeric values for the active members. ChangesMinikube enum API updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🟡 Moderate · up to This update exposes generated Minikube option models, but some option descriptions remain truncated or polluted by default-value text. Consumers of generated documentation or metadata may receive misleading option guidance, so regeneration with the parsing fix is needed before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks each enum line Comment |
ReviewThis PR is an automated regen of the minikube CLI options after a generator change (updated Blocking: doc-comment fix is incomplete, leaves garbled XML docsThe diff appends the correct trailing sentence to three flag descriptions, but leaves a pre-existing garbled fragment in front of it rather than replacing it:
In each case the leading fragment is the tail of minikube's wrapped Why this matters: these are public, shipped XML doc comments — anyone hovering Suggested fix: per CLAUDE.md, fix this in the scraper/generator (not by hand-editing the generated file). Since minikube's cobra help wraps the No other issues found — the JSON manifest hash bump and the rest of the option-class diff look like a clean, expected mechanical regen. |
abae0fa to
3e65df1
Compare
ReviewStill the same automated minikube CLI options regen (only `MinikubeStartOptions.Generated.cs` and the generation manifest touched), and the previously-flagged issue on this PR is still present and unaddressed at the new head. Blocking: doc-comment fix is incomplete, leaves garbled XML docs (unresolved from prior review)The diff appends the correct trailing sentence to three flag descriptions, but still leaves the pre-existing garbled fragment in front of it instead of replacing it:
The leading fragment in each case is the tail of minikube's line-wrapped Why this matters: these are public, shipped XML doc comments. Anyone hovering Suggested fix: per CLAUDE.md, fix this in the scraper/generator, not by hand-editing generated output. Since the underlying generator/scraper code isn't part of this PR's diff, this can't be fixed by editing the generated file here — the generator needs to be fixed first and this PR regenerated from that fix. No other issues — the JSON manifest hash bump and the rest of the option-class diff are otherwise a clean, expected mechanical regen. |
|
The blocking finding is real but the mechanism is different from wrapping: these rows are single lines, and |
3e65df1 to
1313504
Compare
GitHub Actions
Failure
|
Review Same automated minikube CLI options regeneration as before (enum reordering, Previously-flagged garbled XML docs: acknowledged, tracked out-of-band, not actionable here Prior reviews on this PR correctly flagged that However, @thomhurst's follow-up comment explains the root cause and fix path: the scraper's Per this repo's own policy in CLAUDE.md ("Never hand-tweak auto-generated options in a PR... Fix generated-options problems in the scraper or generator, not in generated output"), this PR correctly does not hand-patch the generated file, since that would just be overwritten by the next regen anyway. Once PR 4702 merges, the push-triggered regeneration bot will refresh this branch with clean descriptions automatically. There's nothing actionable to change in this PR's diff; re-flagging the same finding here would just be noise against a fix that's already in flight elsewhere. Enum reordering, the generation-manifest hash bump, and the No actionable findings for this PR. REVIEW_VERDICT_PLACEHOLDER |
|
Review (correction: verdict marker was missing from previous comment) Same automated minikube CLI options regeneration as before (enum reordering, Previously-flagged garbled XML docs: acknowledged, tracked out-of-band, not actionable here Prior reviews on this PR correctly flagged that However, @thomhurst's follow-up comment explains the root cause and fix path: the scraper's Per this repo's own policy in CLAUDE.md ("Never hand-tweak auto-generated options in a PR... Fix generated-options problems in the scraper or generator, not in generated output"), this PR correctly does not hand-patch the generated file, since that would just be overwritten by the next regen anyway. Once PR 4702 merges, the push-triggered regeneration bot will refresh this branch with clean descriptions automatically. There's nothing actionable to change in this PR's diff; re-flagging the same finding here would just be noise against a fix that's already in flight elsewhere. Enum reordering, the generation-manifest hash bump, and the No actionable findings for this PR. |
1313504 to
c112c41
Compare
ReviewSame automated minikube CLI options regeneration verified previously (enum reordering in Enum reordering is safe: all three enums are consumed via Previously-flagged garbled XML docs: No other issues found. This PR is a clean, expected mechanical regen. |
c112c41 to
3393b4e
Compare
ReviewThis is a routine auto-generated regeneration of the Minikube options classes (v1.39.0 CLI scrape). The mechanical parts are correct and consistent with the described breaking-API changes:
Actionable finding: corrupted XML doc summaries from the scraper's default-value parsingThree properties in /// <summary>
/// v0.0.51@sha256:4a1c825b61479e6c898851ea66f13c620aaeab6002746e95067fc2c4b38a0b24': The base image to use for docker/podman drivers. Intended for local development.
/// </summary>
public string? BaseImage { get; set; }/// <summary>
/// //storage.googleapis.com/minikube/iso/minikube-v1.39.0-amd64.iso,https://github.com/kubernetes/minikube/releases/download/v1.39.0/minikube-v1.39.0-amd64.iso,https://kubernetes.oss-cn-hangzhou.aliyuncs.com/minikube/iso/minikube-v1.39.0-amd64.iso]: Locations to fetch the minikube ISO from.
/// </summary>
public string? IsoUrl { get; set; }/// <summary>
/// ///system': The KVM QEMU connection URI. (kvm2 driver only)
/// </summary>
public string? KvmQemuUri { get; set; }These are not usable IntelliSense docs — a truncated sha256 digest, a protocol-stripped URL list, and a bare Since Why this matters: consumers rely on these XML doc comments for IntelliSense/tooltips when configuring pipeline modules; shipping doc text like Suggested fix (in the generator, not the generated output): before the description is captured, strip the Note: this corruption pre-dates this PR — the "before" state for these three properties was already truncated at the colon with no description at all (this PR actually restores the real sentence, just doesn't remove the leftover fragment). |
3393b4e to
ecaeed1
Compare
ReviewThis is an automated Finding: regenerated doc comments still ship corrupted default-value prefixes
In all three cases the default value contains a colon (inside a sha256 hash, a URL list, or a Per repo guidance, generated option files must not be hand-edited -- the real fix belongs in the scraper's description-splitting logic (treat colons inside default-value hashes/URLs/URIs as non-separators, e.g. only split on the first colon following the closing backtick or |
1 participant
Summary
This PR contains automatically generated updates to minikube CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Minikube.Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Minikube.Enums.MinikubeDockerEnvOutput.Json = 2 -> ModularPipelines.Minikube.Enums.MinikubeDockerEnvOutputModularPipelines.Minikube.Enums.MinikubeDockerEnvOutput.Text = 0 -> ModularPipelines.Minikube.Enums.MinikubeDockerEnvOutputModularPipelines.Minikube.Enums.MinikubeDockerEnvOutput.Yaml = 1 -> ModularPipelines.Minikube.Enums.MinikubeDockerEnvOutputModularPipelines.Minikube.Enums.MinikubeImageLsFormat.Json = 2 -> ModularPipelines.Minikube.Enums.MinikubeImageLsFormatModularPipelines.Minikube.Enums.MinikubeImageLsFormat.Short = 0 -> ModularPipelines.Minikube.Enums.MinikubeImageLsFormatRepresentative added members:
ModularPipelines.Minikube.Enums.MinikubeDockerEnvOutput.Json = 0 -> ModularPipelines.Minikube.Enums.MinikubeDockerEnvOutputModularPipelines.Minikube.Enums.MinikubeDockerEnvOutput.Text = 1 -> ModularPipelines.Minikube.Enums.MinikubeDockerEnvOutputModularPipelines.Minikube.Enums.MinikubeDockerEnvOutput.Yaml = 2 -> ModularPipelines.Minikube.Enums.MinikubeDockerEnvOutputModularPipelines.Minikube.Enums.MinikubeImageLsFormat.Json = 0 -> ModularPipelines.Minikube.Enums.MinikubeImageLsFormatModularPipelines.Minikube.Enums.MinikubeImageLsFormat.Short = 1 -> ModularPipelines.Minikube.Enums.MinikubeImageLsFormatCommand coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator