[Automated] Update kubectl CLI Options - #4694
Conversation
thomhurst
added
automated
dependencies
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (44)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Kubernetes public API tracking files update enum member removal records, restore output enum declarations with sequential values, normalize dry-run and cascade values, and rename ChangesKubernetes API tracking
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates Kubernetes CLI option APIs and enum tracking for newer kubectl and Kustomize help output. The documented API changes are intentional, with no current merge-readiness risk identified. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6c0e02d to
506c665
Compare
GitHub Actions
Inactive
Code ReviewReviewed the regenerated Kubernetes options in this PR (this appears to be an automated "update generated CLI options" refresh, similar to #4689). Finding
/// <summary>
-/// :1\]$':
+/// :1\]$': Regular expression for hosts that the proxy should accept.
/// </summary>
[CliOption("--accept-hosts", Format = OptionFormat.EqualsSeparated)]
public string? AcceptHosts { get; set; }The scraper is failing to strip the tail of the This bug pre-dates this PR (the doc was already truncated to just Everything elseThe rest of the diff is standard regenerated output (enums, options, |
506c665 to
3a9bd93
Compare
GitHub Actions
Failure
Code ReviewThis is another automated kubectl CLI-options refresh (same shape as #4689, #4694's own prior push). Scope is entirely Previously-flagged issue: still unresolvedA prior review on this PR (posted against commit
/// <summary>
/// :1\]$': Regular expression for hosts that the proxy should accept.
/// </summary>
[CliOption("--accept-hosts", Format = OptionFormat.EqualsSeparated)]
public string? AcceptHosts { get; set; }This is still present, unchanged, at the current head ( [GeneratedRegex(@"^\s*(?:(?<short>-\w),\s*)?(?<long>--[\w-]+)(?:(?<default>=)(?<type>[^:\s]*))?:\s*(?<desc>.*)?$", RegexOptions.Multiline)]
private static partial Regex KubectlOptionPattern();The The embedded This isn't unique to kubectl's Per repo convention this must be fixed in the scraper ( Everything elseThe enum reordering (e.g.
|
3a9bd93 to
834fbae
Compare
Code ReviewAnother automated kubectl CLI-options refresh (same shape as the prior pushes to this PR, and #4689). Scope is entirely Previously-flagged issue: still unresolvedTwo earlier reviews on this PR (at commits
/// <summary>
/// :1\]$': Regular expression for hosts that the proxy should accept.
/// </summary>
[CliOption("--accept-hosts", Format = OptionFormat.EqualsSeparated)]
public string? AcceptHosts { get; set; }Root cause (confirmed again against the current scraper source, which is untouched by this PR): [GeneratedRegex(@"^\s*(?:(?<short>-\w),\s*)?(?<long>--[\w-]+)(?:(?<default>=)(?<type>[^:\s]*))?:\s*(?<desc>.*)?$", RegexOptions.Multiline)]
private static partial Regex KubectlOptionPattern();
The embedded This isn't unique to Per repo convention this must be fixed in the scraper, not by hand-patching the generated file — and since this PR is just a re-run of the existing generator, every future regeneration will keep reproducing this same garbled doc for Everything elseEnum reordering (e.g. |
834fbae to
2c38b93
Compare
Code ReviewAnother automated kubectl CLI-options refresh (same shape as the prior pushes to this PR, and #4689). Scope is entirely Previously-flagged issue: still unresolved Three earlier reviews on this PR have now flagged the same malformed XML doc comment, and it is still present unchanged at the current head (
/// <summary>
/// :1\]$': Regular expression for hosts that the proxy should accept.
/// </summary>
[CliOption("--accept-hosts", Format = OptionFormat.EqualsSeparated)]
public string? AcceptHosts { get; set; }Root cause (confirmed again — the scraper is untouched by this PR): [GeneratedRegex(@"^\s*(?:(?<short>-\w),\s*)?(?<long>--[\w-]+)(?:(?<default>=)(?<type>[^:\s]*))?:\s*(?<desc>.*)?$", RegexOptions.Multiline)]
private static partial Regex KubectlOptionPattern();
The embedded This isn't unique to Per repo convention ( Everything else
|
1 participant
Summary
This PR contains automatically generated updates to kubectl CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Kubernetes (kubectl).Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRun.Client = 2 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRunModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRun.None = 0 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRunModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRun.Server = 1 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRunModularPipelines.Kubernetes.Enums.KubernetesAnnotateOutput.GoTemplate = 4 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateOutputModularPipelines.Kubernetes.Enums.KubernetesAnnotateOutput.GoTemplateFile = 5 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateOutputRepresentative added members:
ModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRun.Client = 0 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRunModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRun.None = 1 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRunModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRun.Server = 2 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateDryRunModularPipelines.Kubernetes.Enums.KubernetesAnnotateOutput.GoTemplate = 0 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateOutputModularPipelines.Kubernetes.Enums.KubernetesAnnotateOutput.GoTemplateFile = 1 -> ModularPipelines.Kubernetes.Enums.KubernetesAnnotateOutputCommand coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator