Skip to content

SCAL-334820 Split Action.Edit into Action.EditLiveboard and Action.Ed… - #660

Open
ts-nk-github-cplot wants to merge 3 commits into
mainfrom
SCAL-334820
Open

ts-nk-github-cplot wants to merge 3 commits into
mainfrom
SCAL-334820

Conversation

@ts-nk-github-cplot

@ts-nk-github-cplot ts-nk-github-cplot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

…itVisualization

@ts-nk-github-cplot
ts-nk-github-cplot requested a review from a team as a code owner September 8, 2026 10:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new actions, EditLiveboard and EditVisualization, to the Action enum in src/types.ts to allow independent control over editing Liveboards and visualizations. It also adds corresponding unit tests in src/embed/liveboard.spec.ts to verify their independent behavior. There are no review comments, and we have no feedback to provide.

@pkg-pr-new

pkg-pr-new Bot commented Sep 8, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@660

commit: 90f44ba

Comment thread src/types.ts Outdated
Comment thread src/types.ts Outdated

@shivam-kumar-ts shivam-kumar-ts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants