SCAL-301123: Support Hiding the "Customize Homepage" Action in Embeds - #681
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the hideCustomizeHomepageButton configuration option to AppEmbed, enabling users to hide the 'Customize homepage' button on the embedded home page. The changes include updating the AppViewConfig interface, passing the parameter to the iframe URL when defined, updating the Param enum, and adding a unit test. The review feedback correctly identifies a style guide violation in the JSDoc code example for hideCustomizeHomepageButton, where invalid syntax (...) was used inside an object literal.
commit: |
tushardeepakts
changed the title
sastaachar
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
CustomizeHomepage = 'customizeHomepage'to theActionenum so the "Customize homepage" button can be hidden via the standardhiddenActionsmechanism without requiring a one-off flag.Changes
Action.CustomizeHomepageto theActionenum (no extraAppEmbedlogic required ashiddenActionsis already generic).hiddenActions: [Action.CustomizeHomepage]emitshideAction=[...,"customizeHomepage"]in the iframesrc.Screen.Recording.2026-09-23.at.12.19.12.PM.mov