SCAL-332974: Pass liveboardOverride via APP_INIT embedParams for LiveboardEmbed - #683
Merged
Merged
Conversation
…boardEmbed In embed mode ThoughtSpot ignores the filter/parameter URL params and reads the Liveboard filter and Parameter override from embedParams.liveboardOverride instead (mirrors the LiveboardOverride message on LoadPinboardRequest). - Add LiveboardOverride, LiveboardDataSourceOverride, LiveboardFilterQuery and LiveboardParameterQuery public types, exported from both the main and React entry points. - Add liveboardOverride to LiveboardViewConfig and send it in the APP_INIT embedParams. It is omitted when unset or when dataSourceOverride is empty.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for applying filters and parameters to an embedded Liveboard when it loads via the new liveboardOverride configuration. It adds the necessary TypeScript interfaces (LiveboardFilterQuery, LiveboardParameterQuery, LiveboardDataSourceOverride, and LiveboardOverride), utility functions, comprehensive unit tests, and exports these types for external use. Feedback on the changes suggests improving type safety in buildLiveboardOverrideAppInitData by constraining the generic parameter T to include embedParams, thereby eliminating an inline type assertion.
commit: |
sastaachar
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In embed mode ThoughtSpot ignores the filter/parameter URL params and reads the Liveboard filter and Parameter override from embedParams.liveboardOverride instead (mirrors the LiveboardOverride message on LoadPinboardRequest).