Tolerate uv truncated pyvenv.cfg version_info#153
Merged
Conversation
uv 0.11.22 (astral-sh/uv#19890) writes only the major.minor into a seeded venv's pyvenv.cfg (e.g. "3.14") instead of the full "3.14.6". pre-commit's health_check then fails the exact-match comparison against our _version_info override, raising "expected environment to be healthy immediately after install". Override health_check with a prefix-aware comparison that checks only the version components uv actually recorded, so it passes whether uv writes two or three components. Drop the now-redundant _version_info monkeypatch since health_check was its only consumer. Fixes tox-dev#152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
uv
0.11.22(astral-sh/uv#19890) changed seeded venvs to record onlymajor.minorinpyvenv.cfg(e.g.version_info = 3.14) instead of the full3.14.6. pre-commit'shealth_checkdoes an exact-string comparison against our_version_infooverride, so the second hook run failed with:Fix
Override
python.health_checkwith a prefix-aware comparison that checks only the version components uv actually wrote, so it passes whether uv records two or three components. The now-redundant_version_infomonkeypatch is dropped —health_checkwas its only consumer.Verified by reproducing the issue scenario end-to-end with uv
0.11.22(fails onmain, passes here) and added unit tests covering truncated/full/mismatched/missing-config cases.Fixes #152