docs: document additional environment API keys - #4406
Conversation
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdates API key documentation with environment scoping, SDK and self-hosted configuration, key creation, access presets, deployment authentication, expiration, revocation, public tokens, branch targeting, root-key regeneration, and security guidance. Clarifies that numeric public-token expiration values use Unix timestamps in seconds and cannot exceed 30 days. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
11216bf to
94e2d96
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
5125476 to
8cab73f
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
8d3bf1f to
0ab9813
Compare
| ## Self-hosting | ||
|
|
||
| Self-hosted installations support multiple keys with **No restrictions**. The restricted access presets are available in Trigger.dev Cloud. | ||
|
|
||
| Keep your instance and SDK current before creating keys. Calling a public-token API with a key on a server that does not support server-minted tokens returns an upgrade error; use the root key until the server is upgraded. |
There was a problem hiding this comment.
🔍 Self-hosting claim may not hold with the additional-key lookup feature flag off by default
The doc states self-hosted installs support multiple keys with No restrictions. On the server side, resolving an additional (non-root) key is gated by additionalApiKeyLookupEnabled, which is derived from a feature flag that defaults to false (apps/webapp/app/services/authFeatureControls.ts:11), and resolveEnvironmentByApiKey returns { ok: false, reason: "disabled" } when it is off (apps/webapp/app/models/runtimeEnvironment.server.ts:131-134). Worth confirming whether self-hosted deployments enable this flag by default; otherwise the section should mention the required flag/config.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Expands the API key guide to cover root and additional environment keys. It explains how to configure the SDK, create keys with limited access, manage expiration and revocation, rotate the root key, and use keys with public tokens and branch environments.
Design
The guide describes access presets at the product level without exposing authorization internals. It also documents copy-once secrets, immutable access policies, task-selection limits, public-token lifetimes, streamed-batch behavior, and the supported self-hosted configuration.