chore(deps): raise the find-my-way floor - #4639
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## Summary
`packages/core` declared `socket.io`, the server package, but never
imported it. Its only Socket.IO usage is the client:
```
packages/core/src/v3/zodSocket.ts
packages/core/src/v3/runEngineWorker/supervisor/session.ts
import { io } from "socket.io-client";
```
The only occurrence of `socket.io` outside those client imports was the
`package.json` line itself. Since `@trigger.dev/core` is published, that
line meant every consumer installed a server package nothing in the tree
imports.
`socket.io-client` is untouched. `apps/webapp` and `apps/supervisor`
keep their own `socket.io` dependencies, so the server side is
unaffected.
Found with `pnpm run knip:deps`, which the repo already ships.
`pnpm run typecheck` passes across all 57 workspaces, and
`@trigger.dev/core` builds clean.
Stacked on #4639.
Summary
find-my-waywas resolving9.3.0even though its only parent,fastify@5.8.5, declares^9.0.0and so already permitted a newer release. The lockfile had not re-resolved since. This adds a floor so it lands on a current 9.x:It resolves to
9.7.0. Nothing outside the 9.x line is touched, and no parent is asked to accept anything its declared range did not already allow.The whole path is development only:
find-my-wayarrives throughfastify, which arrives throughevalite, a devDependency ofapps/webappused by theeval:devharness.Stacked on #4638.