feat(webapp): show the external deployment id on deployments and runs by 0ski · Pull Request #4665 · triggerdotdev/trigger.dev

0ski · 2026-08-18T13:09:31Z

Deployments page: an always-visible External ID column after Deployed by, and an External ID row in the deployment inspector under Worker type, both showing an en dash when a deploy carried no id. The Vercel Linked column now renders before Git, still only when a Vercel integration is connected. Also corrects the blank-row colSpan, which was already off by one before this column existed.

Run inspector: an External deployment ID row between Version and SDK version, read from the run annotations, so an operator can see which id a run was pinned to - including a run that expired before its deployment ever arrived, where the locked version is empty but the id is the whole story. Buffered runs read the id from the same annotations rather than reporting none.

Long ids are head-truncated with the full value behind the copy button: a commit SHA is meaningful in its prefix, and the inspector panel can be narrowed to 250px, where an unbroken 40-character SHA would otherwise scroll the properties list sideways and push the copy button off-panel (TRI-12923, TRI-13000).

changeset-bot · 2026-08-18T13:09:41Z

⚠️ No Changeset found

Latest commit: 0110494

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-08-18T13:09:50Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 692f2914-c755-41fa-8b1d-be0835191a2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

pkg-pr-new · 2026-08-18T18:53:57Z

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@0110494

trigger.dev

npm i https://pkg.pr.new/trigger.dev@0110494

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@0110494

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@0110494

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@0110494

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@0110494

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@0110494

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@0110494

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@0110494

commit: 0110494

Deployments page: an always-visible External ID column after Deployed by, and an External ID row in the deployment inspector under Worker type, both showing an en dash when a deploy carried no id. The Vercel Linked column now renders before Git, still only when a Vercel integration is connected. Also corrects the blank-row colSpan, which was already off by one before this column existed. Run inspector: an External deployment ID row between Version and SDK version, read from the run annotations, so an operator can see which id a run was pinned to - including a run that expired before its deployment ever arrived, where the locked version is empty but the id is the whole story. Buffered runs read the id from the same annotations rather than reporting none. Long ids are head-truncated with the full value behind the copy button: a commit SHA is meaningful in its prefix, and the inspector panel can be narrowed to 250px, where an unbroken 40-character SHA would otherwise scroll the properties list sideways and push the copy button off-panel (TRI-12923, TRI-13000).

devin-ai-integration

Devin Review found 1 new potential issue.

…ed parked runs (#4708) Two defects that surface when a run parked on an external deployment id gets pushed by a debounce key. Both were reproduced against a local instance before being fixed. ## 1. The run is expired before it is due ``` now | status | statusReason | delayUntil | expiredAt 13:57:06 | EXPIRED | EXTERNAL_DEPLOYMENT_NOT_FOUND | 14:01:37 | 13:57:02 ``` Killed 4m35s before its own scheduled start, blaming a missing deployment. **Why.** The park deadline is armed **once**, when the run is first parked, from `max(now, delayUntil) + deadline`. Debounce pushes `delayUntil` out afterwards and nothing re-arms it: - `rescheduleDelayedRun` reschedules `enqueueDelayedRun:<id>`, not `expireParkedExternalDeploymentRun:<id>` - the redis-worker reschedule is an update-only `ZADD … XX`, and a parked run has no `enqueueDelayedRun` job, so that call is a silent no-op Repeat triggers on one key walk `delayUntil` away from a deadline that no longer moves. Once it crosses, the run dies while parked and not yet due. **Fix.** The expiry job already loads `delayUntil`, so it re-arms from the current value and returns instead of expiring a run that is not due. The guard lives in the expiry job rather than the debounce path deliberately: it covers **every** caller that moves `delayUntil`, so a future call site can't reintroduce this by forgetting to re-arm. It stays bounded by the debounce max-duration contract, so a hot key can't postpone expiry indefinitely. ## 2. The run reports itself as delayed while it is parked ``` RUN_CREATED | PENDING_VERSION | Run is waiting for a deployment of 'debounce-test-2' DELAYED | DELAYED | Delayed run was rescheduled to a future date ← after one debounce push ``` The row stays `PENDING_VERSION`; the latest snapshot claims `DELAYED`, so the run page describes a parked run as delayed. Happens on the *first* push. **Fix.** `rescheduleRun` hardcoded `DELAYED`/`DELAYED`. The snapshot statuses are now supplied by the caller and **default to `DELAYED`**, so the ordinary delayed path is byte-identical, and `rescheduleDelayedRun` passes the parked statuses through when the run is parked. ## Reproducing Repeated triggers on one debounce key against an id that hasn't landed: ```bash curl … -d '{"options":{"externalDeploymentId":"x","debounce":{"key":"k","delay":"5m"}}}' ``` Three triggers correctly fold into one parked run; the defects show up on the pushes. ## Testing Two tests, each verified red before green and failing alone: - a run whose delay was pushed past the deadline stays `PENDING_VERSION` instead of expiring - a debounce push on a parked run leaves a `RUN_CREATED`/`PENDING_VERSION` snapshot, not `DELAYED` `56 passed` across parking, pendingVersion, delayedRunSystem and debounce; `43 passed` in `PostgresRunStore`. Typecheck, lint, format clean. ## Notes - Stacks on #4665, so it lands after the whole external-deployment-id series. - No changeset: this fixes unreleased behaviour introduced by the stack below it, so no user has seen it. - Both found by Devin's review on #4664, and both confirmed end to end on a local instance before fixing.

0ski marked this pull request as ready for review August 18, 2026 13:15

devin-ai-integration Bot reviewed Aug 18, 2026

View reviewed changes

ericallam approved these changes Aug 18, 2026

View reviewed changes

0ski force-pushed the oskar/feat-external-id-dashboard branch from 5966edc to 788053f Compare August 18, 2026 18:51

0ski force-pushed the oskar/feat-external-id-dashboard branch from 788053f to 2bcd612 Compare August 19, 2026 10:37

0ski force-pushed the oskar/feat-external-id-dashboard branch from 2bcd612 to e7c01e8 Compare August 19, 2026 11:29

0ski force-pushed the oskar/feat-external-id-dashboard branch from e7c01e8 to 8e6ae1e Compare August 19, 2026 11:58

0ski force-pushed the oskar/feat-external-id-dashboard branch from 8e6ae1e to 0110494 Compare August 19, 2026 12:44

devin-ai-integration Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread apps/webapp/app/presenters/v3/SpanPresenter.server.ts

0ski mentioned this pull request Aug 19, 2026

fix(run-engine): correct park deadline and snapshot state for debounced parked runs #4708

Merged

0ski merged commit cde8919 into main Aug 19, 2026
41 checks passed

0ski deleted the oskar/feat-external-id-dashboard branch August 19, 2026 15:44

github-actions Bot mentioned this pull request Aug 19, 2026

chore: release v4.5.12 #4610

Merged

Navigation Menu

Uh oh!

Uh oh!

feat(webapp): show the external deployment id on deployments and runs - #4665

feat(webapp): show the external deployment id on deployments and runs#4665
0ski merged 1 commit into
oskar/feat-external-id-triggerfrom
oskar/feat-external-id-dashboard

0ski commented Aug 18, 2026

Uh oh!

changeset-bot Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 18, 2026 •

edited

Loading

Review skipped

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

pkg-pr-new Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

0ski commented Aug 18, 2026

Uh oh!

changeset-bot Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

pkg-pr-new Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Aug 18, 2026 •

edited

Loading

coderabbitai Bot commented Aug 18, 2026 •

edited

Loading

pkg-pr-new Bot commented Aug 18, 2026 •

edited

Loading